fix(ws) onSocketClose being called multiple times#4632
Merged
mcollina merged 4 commits intonodejs:mainfrom Oct 19, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4632 +/- ##
==========================================
- Coverage 92.94% 92.92% -0.02%
==========================================
Files 106 106
Lines 33092 33086 -6
==========================================
- Hits 30756 30746 -10
- Misses 2336 2340 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Uzlopak
requested changes
Oct 18, 2025
Contributor
Uzlopak
left a comment
There was a problem hiding this comment.
Instead of awaiting t.completed, you should await some resonable time like 250 ms.
Also dont use tspl, but use directly t.plan. tspl passes even if you have some asynchronous Activity after the test ended.
t.plan in node 20 works but does not have the waitFor option like in node 22+.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4628
closes #4631
isConnecting = state is 0 (CONNECTING)
onSocketClose sets state to 2 (CLOSING)
this way onSocketClose can only be called once
from #4631: