Skip to content

feat(nuxi): reload nuxt when restart hook is called#19084

Merged
danielroe merged 7 commits into
nuxt:mainfrom
Baroshem:main
Mar 1, 2023
Merged

feat(nuxi): reload nuxt when restart hook is called#19084
danielroe merged 7 commits into
nuxt:mainfrom
Baroshem:main

Conversation

@Baroshem

@Baroshem Baroshem commented Feb 16, 2023

Copy link
Copy Markdown
Contributor

🔗 Linked issue

#18678

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolves #18678

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox

codesandbox Bot commented Feb 16, 2023

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

pi0
pi0 reviewed Feb 16, 2023
View reviewed changes
Comment thread packages/nuxi/src/commands/dev.ts Outdated
pi0
pi0 approved these changes Feb 16, 2023
View reviewed changes

@pi0 pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Baroshem @pi0
Update packages/nuxi/src/commands/dev.ts
240615a 
Co-authored-by: pooya parsa <pyapar@gmail.com>
@danielroe danielroe added this to the v3.3 milestone Feb 16, 2023
danielroe
danielroe reviewed Feb 16, 2023
View reviewed changes
Comment thread packages/nuxi/src/commands/dev.ts Outdated
danielroe
danielroe reviewed Feb 16, 2023
View reviewed changes
Comment thread packages/schema/src/types/hooks.ts
danielroe
danielroe reviewed Feb 16, 2023
View reviewed changes
Comment thread docs/3.api/4.advanced/1.hooks.md Outdated
@danielroe danielroe changed the title feat-#18678: add restart hook feat(nuxi): reload nuxt when restart hook is called Feb 16, 2023
danielroe
danielroe approved these changes Feb 16, 2023
View reviewed changes

@danielroe danielroe left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👌

(Deferring to v3.3 release as it's a feature.)

@danielroe danielroe added ✨ enhancement New feature or improvement to existing functionality 3.x cli Nuxt CLI (nuxi) 🍰 p2-nice-to-have Nice to have, not blocking labels Feb 16, 2023
danielroe
danielroe reviewed Mar 1, 2023
View reviewed changes
Comment thread docs/3.api/4.advanced/1.hooks.md Outdated
@danielroe danielroe merged commit 5cfd835 into nuxt:main Mar 1, 2023
@pi0 pi0 mentioned this pull request Mar 1, 2023
Closed
@danielroe danielroe mentioned this pull request Mar 8, 2023
Merged
@renovate renovate Bot mentioned this pull request Apr 4, 2023
Open
1 task
@renovate renovate Bot mentioned this pull request May 16, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielroe danielroe danielroe approved these changes
@TheAlexLichter TheAlexLichter TheAlexLichter approved these changes
@pi0 pi0 pi0 approved these changes

Assignees

No one assigned

Labels

3.x cli Nuxt CLI (nuxi) ✨ enhancement New feature or improvement to existing functionality 🍰 p2-nice-to-have Nice to have, not blocking

Projects

None yet

Milestone

v3.3

Development

Successfully merging this pull request may close these issues.

Add hook to restart the nuxt server

4 participants

@Baroshem @TheAlexLichter @pi0 @danielroe