Skip to content

feat(nuxt): support app config for server routes#19489

Merged
danielroe merged 14 commits into
mainfrom
feat/server-app-config
Mar 14, 2023
Merged

feat(nuxt): support app config for server routes#19489
danielroe merged 14 commits into
mainfrom
feat/server-app-config

Conversation

@pi0

@pi0 pi0 commented Mar 6, 2023

Copy link
Copy Markdown
Member

🔗 Linked issue

#14670 via nitrojs/nitro#1022

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This feature supports useAppConfig for nitro server routes and seamless integration with nuxt (public) app.config.ts in project's root level. In addition to this nitro also supports server/app.config.ts for private app config.

(pending nitropack release made PR early to preview)

Next steps

  • Bundle app config only once to the server. Currently it bundles to both vite server and nitro server while nitro could expose it for vite on (production build) for server-side.
  • Allow to explicitly provide private app.config, (we might think about a new server.config/serverConfig however there might be better alternatives we could think later)

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox

codesandbox Bot commented Mar 6, 2023

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@pi0 pi0 mentioned this pull request Mar 6, 2023
6 tasks
@danielroe danielroe added ✨ enhancement New feature or improvement to existing functionality 3.x nitro Nitro server engine integration 🍰 p2-nice-to-have Nice to have, not blocking labels Mar 6, 2023
@danielroe danielroe added this to the v3.3 milestone Mar 6, 2023
@danielroe danielroe mentioned this pull request Mar 8, 2023
@pi0 pi0 marked this pull request as ready for review March 13, 2023 19:36
@danielroe danielroe merged commit e84ec61 into main Mar 14, 2023
@danielroe danielroe deleted the feat/server-app-config branch March 14, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x ✨ enhancement New feature or improvement to existing functionality nitro Nitro server engine integration 🍰 p2-nice-to-have Nice to have, not blocking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants