Fix noop_with_empty_axes in reduce ops #7394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
ba2a8bc to
d39343c
Compare
Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
justinchuby
approved these changes
Oct 15, 2025
Member
justinchuby
left a comment
There was a problem hiding this comment.
Thanks! cc @fdwr for another eye
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7394 +/- ##
==========================================
+ Coverage 54.43% 54.45% +0.02%
==========================================
Files 511 511
Lines 31892 31876 -16
Branches 2876 2868 -8
==========================================
- Hits 17360 17359 -1
+ Misses 13741 13734 -7
+ Partials 791 783 -8 ☔ View full report in Codecov by Sentry. |
gramalingam
reviewed
Oct 20, 2025
| def handle_axes(self, axes, noop_with_empty_axes=False): # noqa: PLR0911 | ||
| if isinstance(axes, tuple): | ||
| if len(axes) == 0: | ||
| if len(axes) == 0 and not noop_with_empty_axes: |
Contributor
There was a problem hiding this comment.
So: I guess the numpy convention is that axes=None means reduce over all axes?
justinchuby
added a commit
that referenced
this pull request
Oct 21, 2025
Follow up to #7394 : improving the documentation. (The documentation seems to have undergone several changes, please let me know if you have any concerns with the wording.) --------- Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: justinchuby <11205048+justinchuby@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6103
Credits to: https://github.com/fdwr