feat: support csv in fga tuple delete#478
Conversation
* `fga tuple delete --file=(*.yaml|*csv)` * The tuple delete command now supports reading values of a csv file as well
|
👋🏻 @bensooraj, I saw you ticked Could you link the docs PR too? As, it would be super helpful if we can have docs change too along with the product side change. Let me know, if you need any help with that. For context: We have our docs here |
Siddhant-K-code
left a comment
There was a problem hiding this comment.
Great PR! The changes improve code organization and add solid test coverage. A few minor suggestions for future improvements (suggested below)
These are minor suggestions - the PR is solid and ready to merge as is. Thanks for the improvements!
I have added documentation at openfga.dev#1004 |
|
@bensooraj can you please fix the lint errs |
…openfga/openfga/pkg/tuple/tuple.go`
I thought I did, my bad. I have fixed those as well. |
Siddhant-K-code
left a comment
There was a problem hiding this comment.
Changes looks good to me.
Will also someone from @openfga/dx team for a final review & then we can merge
|
@bensooraj Thanks for the contribution and, @Siddhant-K-code, thanks for the review! We will assign someone in our planning meeting this week to pick this one up for a final review. |
|
Hi @bensooraj, we discussed this PR during our planning meeting. We've put it in the queue for someone to pick up. They will have a full review for you next week. Thanks! |
rhamzeh
left a comment
There was a problem hiding this comment.
Thanks @bensooraj for the contribution and @Siddhant-K-code for the help reviewing!
|
Needs #489 to be merged first so that the lint issues pass, then we can merge this |
Description
fga tuple delete --file=(*.json|*.yaml|*csv)*.csvfile as wellReferences
Review Checklist
main