Conversation
WalkthroughUpdates CHANGELOG.md with an Unreleased 0.7.5 entry documenting a new configurable --page-size for fga tuple read (with defaulting rules) and a change to import behavior to ignore duplicate tuples (requires OpenFGA v1.10.0+); also notes a fix for retrying 5xx errors. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant CLI as CLI (user)
participant Client as OpenFGA Client
participant Server as OpenFGA Server
rect rgb(230,245,255)
CLI->>Client: tuple read (--max-pages, --page-size)
Client->>Server: ReadTuples(pageSize)
Server-->>Client: TuplePage (may be multiple pages)
Client-->>CLI: Aggregated tuples
end
rect rgb(245,255,230)
CLI->>Client: import tuples (file)
Client->>Server: WriteTuples(import=true)
note right of Server: If server >= v1.10.0 -> ignore duplicate writes\nelse -> previous duplicate handling applies
Server-->>Client: Import result (duplicates ignored or error)
Client-->>CLI: Import report
end
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
0ae41f8 to
2faa374
Compare
2faa374 to
91bc223
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
CHANGELOG.md (1)
21-22: Wrap the bare URL in markdown link formatting.
markdownlintflags bare URLs; consider converting this to[link text](url)to keep lint clean.-- Issue retrying 5xx errors. Fixed upstream (https://github.com/openfga/go-sdk#204) +- Issue retrying 5xx errors. Fixed upstream ([openfga/go-sdk#204](https://github.com/openfga/go-sdk#204))
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
CHANGELOG.md(2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
CHANGELOG.md
22-22: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Tests
91bc223 to
5125ba1
Compare
5125ba1 to
001086d
Compare
Description
Changes
Added:
--page-sizeparameter tofga tuple readcommand with intelligent defaults (#571)--max-pages=0(read all tuples), defaults to 100 for better efficiency--max-pages!=0(limited pages), defaults to 50 to maintain backward compatibility--page-sizeflagChanged:
Fixed:
What problem is being solved?
How is it being solved?
What changes are made to solve it?
References
Review Checklist
mainSummary by CodeRabbit
New Features
Changed
Documentation