Skip to content

Conversation

@walulyai
Copy link
Member

@walulyai walulyai commented Sep 7, 2020

"We agreed in an internal discussion to remove that check from region selection completely - the rationale is that when we already started a (mixed) gc, we should evacuate as much as possible. So that check may at least moved out of the loop or completely removed."


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252658: G1: Do not consider G1HeapWastePercent during region selection within a gc

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/62/head:pull/62
$ git checkout pull/62

@walulyai
Copy link
Member Author

walulyai commented Sep 7, 2020

/label add hotspot-gc

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 7, 2020

👋 Welcome back iwalulya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Sep 7, 2020
@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@walulyai
The hotspot-gc label was successfully added.

@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@walulyai To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request.

In order to have an RFR email automatically sent to the correct mailing list, you will need to add one or more labels manually using the /label add "label" command. The following labels are valid: 2d awt beans build compiler core-libs hotspot hotspot-compiler hotspot-gc hotspot-jfr hotspot-runtime i18n javadoc jdk jmx kulla net nio security serviceability shenandoah sound swing.

@walulyai
Copy link
Member Author

walulyai commented Sep 7, 2020

/issue add 8252658

@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@walulyai This issue is referenced in the PR title - it will now be updated.

@walulyai walulyai marked this pull request as ready for review September 7, 2020 15:03
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 7, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 7, 2020

Webrevs

@mlbridge
Copy link

mlbridge bot commented Sep 8, 2020

Mailing list message from Thomas Schatzl on hotspot-gc-dev:

Hi,

On 07.09.20 17:07, Ivan Walulya wrote:

lgtm.

Thomas

@openjdk
Copy link

openjdk bot commented Sep 8, 2020

@walulyai This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8252658: G1: Do not consider G1HeapWastePercent during region selection within a gc

Reviewed-by: tschatzl, sjohanss
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 16 commits pushed to the master branch:

  • 001e51d: 8250563: Add KVHashtable::add_if_absent
  • 91a20ca: 8252695: Shenandoah: clean up Graal enabled/disabled filter in tests
  • 704f784: 8252871: fatal error: must own lock JvmtiThreadState_lock
  • bf5da0c: 8252897: Minor .jcheck/conf update
  • 7600274: 8252859: Inconsistent use of alpha in class AbsSeq
  • 4fb1980: 8252853: AArch64: gc/shenandoah/TestVerifyJCStress.java fails intermittently with C1
  • 73ba3ae: 8252500: ZGC on aarch64: Unable to allocate heap for certain Linux kernel configurations
  • 5dd1ead: 8252767: URLConnection.setRequestProperty throws IllegalAccessError
  • 2cceeed: 8166554: Avoid compilation blocking in OverloadCompileQueueTest.java
  • 188b0bc: 8252868: Clean up unused function from G1MMUTracker
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/e0c8d4420c8e1a84581927cf77314498b8e5aa52...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 001e51d96553b62adfe89a54a7b6eedabbd4e9b1.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tschatzl, @kstefanj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 8, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 8, 2020

Mailing list message from Ivan Walulya on hotspot-gc-dev:

Thanks Thomas!

On 8 Sep 2020, at 16:58, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:

Hi,

On 07.09.20 17:07, Ivan Walulya wrote:

lgtm.

Thomas

Copy link
Contributor

@kstefanj kstefanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me too 👍

@walulyai
Copy link
Member Author

walulyai commented Sep 8, 2020

thanks @kstefanj

@walulyai
Copy link
Member Author

walulyai commented Sep 8, 2020

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 8, 2020
@openjdk
Copy link

openjdk bot commented Sep 8, 2020

@walulyai
Your change (at version 5e37b20) is now ready to be sponsored by a Committer.

@kstefanj
Copy link
Contributor

kstefanj commented Sep 8, 2020

/sponsor

@openjdk openjdk bot closed this Sep 8, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 8, 2020
@openjdk
Copy link

openjdk bot commented Sep 8, 2020

@kstefanj @walulyai Since your change was applied there have been 16 commits pushed to the master branch:

  • 001e51d: 8250563: Add KVHashtable::add_if_absent
  • 91a20ca: 8252695: Shenandoah: clean up Graal enabled/disabled filter in tests
  • 704f784: 8252871: fatal error: must own lock JvmtiThreadState_lock
  • bf5da0c: 8252897: Minor .jcheck/conf update
  • 7600274: 8252859: Inconsistent use of alpha in class AbsSeq
  • 4fb1980: 8252853: AArch64: gc/shenandoah/TestVerifyJCStress.java fails intermittently with C1
  • 73ba3ae: 8252500: ZGC on aarch64: Unable to allocate heap for certain Linux kernel configurations
  • 5dd1ead: 8252767: URLConnection.setRequestProperty throws IllegalAccessError
  • 2cceeed: 8166554: Avoid compilation blocking in OverloadCompileQueueTest.java
  • 188b0bc: 8252868: Clean up unused function from G1MMUTracker
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/e0c8d4420c8e1a84581927cf77314498b8e5aa52...master

Your commit was automatically rebased without conflicts.

Pushed as commit 63a5a12.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

caojoshua pushed a commit to caojoshua/jdk that referenced this pull request Jul 26, 2023
* JVM-2253: Merge allocation state in PredictedCallGenerator and
PredicatedIntrinsicGenerator

This patch merges allocation states for PredictedCallGenerator.

* Use merge_at_phi_creation in parse_common().

---------

Co-authored-by: Xin Liu <xxinliu@amazon.com>
dansmithcode pushed a commit to dansmithcode/jdk that referenced this pull request Aug 31, 2024
* Update LICENSE file

* The experimental version is aimed to refactor the tool

* verificationType mistakenly added to source code is renamed to type

* Adapted mvn bindings to at8

* Added tests to represent bad stream handling in jdec and correctone in jdis

* Made jdec to write output to proper toolOutput instead of bad logOutput

* 7903208: [Jasm] Add support for generics (the Signature attribute)

* 7902888: Excess entries in BootstrapMethods with the same bsm, bsmKind, bsmArgs

* Replaced hardcoded String[] args, by varargs String... where reasonable

Once the "tool" mandatory array memebr was removed from each tool's main
method, and considering calls from libraries, and form tests where the
argument is very often just one file, or more readable "a1", a2"...
without new String[]{} declaration, changed those String[] enforcing
headers to more benevolent String...

* Intentionally removed ACC_SUPER class modifier was causing hotswap to fail

When jasm's  disasm, modify, asm cycle output binary was used for class
hotswap, remote JDK was not accepting it with java.lang.UnsupportedOperationException:
class redefinition failed: attempted to change the class modifiers
beacuse of ommited supoer keyword (although it have already no real
reason)

This patch is returning the kwyword without conditions, when it was
included in original bytecode

* extended test to verify that super is not used always

if super is not in source code, then it is not in disambled code

* 7903248: jasm: FieldData.ConstantValue holds undefined reference to CP while writing fields to a class

* Added support for stdin in jdis

* stdin is now read also by jasm,jcod,jdec

more tests needed

* Removed jdis specific missleading provide method

* Tool output moved where it belongs to commons

* Removed duplicated declaration of ArrayList<ToolInput> fileList

* Changed requireNonNull message in getDataInputStream

* Added one more abstraction layer providing highly reusable byte[] based input

* Properly exiting after verson is printed

* Stream based inputs are now drained once needed, not during construction

* reworked stdin read to be initiated by -

As a side effect, files and stdin can be read together
remove dduplicated code in tests by getting class in compile time
added tests and adapted older to new behavior

* added tests if asmtools assmble itself into valid bytecode

Added two set of tests
jdec->jcoder->load
jdis->jasm->load
Both in two variants, with -g, and without

Both jdec->jcoder->load works fine
Both jdis->jasm->load now fails on three files from 278:
 /org/openjdk/asmtools/jasm/JasmEnvironment$InputFile.class, /org/openjdk/asmtools/jcoder/Jcoder.class, /org/openjdk/asmtools/jasm/Parser.class
Fail looks valid.

Unluckily, the issue where -g disassembled and back assembled
com.google.gson.Gson produce invalid bytecode was not hit

The class BruteForceHelper is reusable for any set of classes

* Naive fix for enforced dot.suffix

* repalce stdout by configurable object

This checkout is not buildable, but server as showcase for issue with
dual logging for compilers

* Replaced dualstream logger by wrapper

so it can  be later made fully customisable

* Enabled shared i18n properties via reused asmtools/i18n.props

* All four tools now use neww ToolOutput output

As a consequence, all four tools by by default prints to stdout, and
honours -d properly

* Fixed typo which casued behavior regression

found by unittests

* Refatoed tests so they can harbour resources in maven way

* Moved all logging to stderr. use -dls to return original behavior

The -dls switch  is oging to be removed once stderr is properl adapted

* Implemented library-like input and output

This commit is adding byte[]/String  input/output clasases for direct
library usage.
Added tests, advertising how simple is usage of those inputs/outputs

There are two hunks, which fixes issues ovberlooked in previous
refactorings:
 - traceln now correctly calls getOutputs
 - jdec now uses proper logger insted of accidental stderr

* Enabled -g for jcoder to be set from external code

* Temporary workaround around tests being order-sensitive

As -g is now making some disassmebld code not asemble-able back, and
order of tests is not deterministic, and Options are static, thus if -g
is now set in some test, it is not unset in other tests.

Real fix is to move Options out of static context to context of
environment as it is done for jcoder.

* Added github actions

Just for record for "act" for local testing. To run with podman based distros, several steps are ncessary. See nektos/act#303 ; especially
 * nektos/act#303 (comment)
 *  and nektos/act#303 (comment)
    *   the bind and socket
eg:
 systemctl enable --now --user podman.socket
 systemctl start --user podman.socket
 export DOCKER_HOST=unix://$XDG_RUNTIME_DIR/podman/podman.sock
 ../act/bin/act   --bind --container-daemon-socket $XDG_RUNTIME_DIR/podman/podman.sock

 To rerun the build on clean env, you have to stop and start the podman socket again

Without explicit 'mvn test' the tests are not running. Not sure why

* 7902888: Excess entries in BootstrapMethods with the same bsm, bsmKind, bsmArgs

* Fixed issue when jasm produced only one file from source with multiple ones

Added tests for this issue
Added test veryfying that the jcoder is not affected

* 7903401: jtreg fails if set of jdk tests process jasm,jdis files with defects

* 7903402: jdis: tool writes incorrect StackMapTable if the first same_frame has type 0 (openjdk#51)

* 7902888: Excess entries in BootstrapMethods with the same bsm, bsmKind, bsmArgs

* 7903401: jtreg fails if set of jdk tests process jasm,jdis files with defects

* 7903402: jdis: tool writes incorrect StackMapTable if the first same_frame has type 0

* 7902888: Excess entries in BootstrapMethods with the same bsm, bsmKind, bsmArgs

* Refactored new ToolInput/Outputs so they reside in own packages and not in original interfaces (openjdk#53)

* Refactored new ToolInput/Outputs so they reside in own packages and not in original interfaces

* Removed unused imports

* Added licence headers

* Added ajvadoc description to three main interfaces.

* Removed unnecessary guard condition before changging \ to / for fqn

* Replaced "\n" by System.lineSeparator()

* Used better names for highlighted abbrevations

* 7903405: compiler does not warn about instruction arguments that exceed allowed limits (openjdk#54)

* 7902888: Excess entries in BootstrapMethods with the same bsm, bsmKind, bsmArgs

* 7903401: jtreg fails if set of jdk tests process jasm,jdis files with defects

* 7903402: jdis: tool writes incorrect StackMapTable if the first same_frame has type 0

* 7902888: Excess entries in BootstrapMethods with the same bsm, bsmKind, bsmArgs

* 7903405: compiler does not warn about instruction arguments that exceed allowed limits

* 7903405: compiler does not warn about instruction arguments that exceed allowed limits

* Delete ToolOutput.java

* Fixed junit test for CODETOOLS-7903405 (openjdk#56)

* 7903458: Umbrella: Preparations for switching to Asmtools 8.0 (openjdk#57)

* 7903458: Umbrella: Preparations for switching to Asmtools 8.0

* Fix tabs

* 7903458: Umbrella: Preparations for switching to Asmtools 8.0 (Part II) (openjdk#58)

* 7903458: Umbrella: Preparations for switching to Asmtools 8.0

* Fix tabs

* 7903458: Umbrella: Preparations for switching to Asmtools 8.0

* 7903458: Umbrella: Preparations for switching to Asmtools 8.0

* CODETOOLS-7903506: Asmtools: jdis prints BootstrapMethod attribute if detailed output is off (openjdk#59)

* 7903458: Umbrella: Preparations for switching to Asmtools 8.0

* Fix tabs

* 7903458: Umbrella: Preparations for switching to Asmtools 8.0

* 7903458: Umbrella: Preparations for switching to Asmtools 8.0

* 7903506: Asmtools: jdis prints BootstrapMethod attribute if detailed output is off

* 7903509: jcoder, jasm: add option to override class file version in source file(s) (openjdk#60)

* 7903458: Umbrella: Preparations for switching to Asmtools 8.0

* Fix tabs

* 7903458: Umbrella: Preparations for switching to Asmtools 8.0

* 7903458: Umbrella: Preparations for switching to Asmtools 8.0

* 7903509: jcoder, jasm: add option to override class file version in source file(s)

* CODETOOLS-7903531: jdis: Suppress printing comments by adding an option (openjdk#61)

* 7903458: Umbrella: Preparations for switching to Asmtools 8.0

* Fix tabs

* 7903458: Umbrella: Preparations for switching to Asmtools 8.0

* 7903458: Umbrella: Preparations for switching to Asmtools 8.0

* 7903531: jdis: Suppress printing comments by adding an option

---------

Co-authored-by: Jiri Vanek <jvanek@redhat.com>
pf0n pushed a commit to pf0n/jdk that referenced this pull request Jul 9, 2025
* Further improvements to histogram

1. Replace "*" with "1" in each histogram column.  With this change, each histogram column reads as a binary number.

2. Adjust the span of histogram columns so that it ranges from the first non-empty tally of responses instead of sometimes starting with a negative response time.

3. Label each non-empty column of the histogram with the upper bound on response times for values corresponding to that column.

* Cosmetic improvements

Remove tab characters.  Append newlines to end of files missing these.  Add two copyright notices.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants