Skip to content

Make empty_symint support dynamism.#4550

Merged
vanbasten23 merged 1 commit into
masterfrom
fixEmptySymintMaster
Feb 2, 2023
Merged

Make empty_symint support dynamism.#4550
vanbasten23 merged 1 commit into
masterfrom
fixEmptySymintMaster

Conversation

@vanbasten23

@vanbasten23 vanbasten23 commented Feb 1, 2023

Copy link
Copy Markdown
Collaborator

To address comment #4524 (comment).

@vanbasten23 vanbasten23 marked this pull request as ready for review February 1, 2023 20:44
@vanbasten23 vanbasten23 assigned miladm and unassigned miladm Feb 1, 2023
@vanbasten23 vanbasten23 requested a review from miladm February 1, 2023 20:46
Comment thread test/cpp/test_aten_xla_tensor.cpp
Comment thread test/test_dynamic_shapes.py

@alanwaketan alanwaketan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vanbasten23 vanbasten23 added the dynamism Dynamic Shape Features label Feb 2, 2023
@vanbasten23 vanbasten23 merged commit 34e9115 into master Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dynamism Dynamic Shape Features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants