Skip to content

fix doc title displayed as untitled#4008

Merged
chemicL merged 1 commit intoreactor:3.7.xfrom
dev-jonghoonpark:4006-fix-doc-title-displayed-as-untitled
Mar 10, 2025
Merged

fix doc title displayed as untitled#4008
chemicL merged 1 commit intoreactor:3.7.xfrom
dev-jonghoonpark:4006-fix-doc-title-displayed-as-untitled

Conversation

@dev-jonghoonpark
Copy link
Contributor

Fix issue #4006

@dev-jonghoonpark dev-jonghoonpark requested a review from a team as a code owner March 7, 2025 15:39
@chemicL chemicL changed the base branch from main to 3.7.x March 10, 2025 13:32
@chemicL chemicL changed the base branch from 3.7.x to main March 10, 2025 13:32
@chemicL
Copy link
Member

chemicL commented Mar 10, 2025

Thanks. Would you mind rebasing this change on top of 3.7.x branch so that we can include the fixes into the current released version and not just the future release (main)?

@chemicL chemicL added the type/documentation A documentation update label Mar 10, 2025
@dev-jonghoonpark
Copy link
Contributor Author

@chemicL
Sure, that's possible! Just to confirm, should I create a new PR with the changes rebased onto the 3.7.x branch?

@chemicL
Copy link
Member

chemicL commented Mar 10, 2025

You could just use git rebase --onto, force push to your branch and change the base of this PR.

Signed-off-by: dev-jonghoonpark <dev@jonghoonpark.com>
@dev-jonghoonpark dev-jonghoonpark force-pushed the 4006-fix-doc-title-displayed-as-untitled branch from 9c83cac to c8928a9 Compare March 10, 2025 13:54
@dev-jonghoonpark
Copy link
Contributor Author

Thank you for your guidance.
As per your instructions, I performed the rebase and force push.
Could you please check if everything is correct?

@chemicL chemicL changed the base branch from main to 3.7.x March 10, 2025 14:01
@chemicL chemicL added this to the 3.7.4 milestone Mar 10, 2025
@chemicL chemicL merged commit 65e6b4e into reactor:3.7.x Mar 10, 2025
9 checks passed
chemicL added a commit that referenced this pull request Mar 10, 2025
@chemicL
Copy link
Member

chemicL commented Mar 10, 2025

Thank you for the contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/documentation A documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants