Reduce log level to warn on reconnect in JedisSentinelPool#4336
Merged
Reduce log level to warn on reconnect in JedisSentinelPool#4336
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reduces the logging severity level from ERROR to WARN when a connection to a Sentinel is lost and will be automatically retried. This is appropriate since the condition is recoverable and doesn't represent a critical failure.
Key Changes:
- Changed log level from
LOG.error()toLOG.warn()for Sentinel reconnection attempts
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Test Results 280 files ±0 280 suites ±0 11m 32s ⏱️ -20s Results for commit ce9d3e7. ± Comparison against base commit 4ddd7f4. This pull request skips 1011 tests.♻️ This comment has been updated with latest results. |
Losing connection to a Sentinel is a normal operational event. Sentinels can be restarted for maintenance, or because of network hiccups. The code automatically retries and recovers
ggivo
added a commit
that referenced
this pull request
Nov 6, 2025
…#4336) * Reduce log level to warn on reconnect in JedisSentinelPool * reduce log level to WARN in SentineledConnectionProvider #4330 Losing connection to a Sentinel is a normal operational event. Sentinels can be restarted for maintenance, or because of network hiccups. The code automatically retries and recovers --------- Co-authored-by: ggivo <ivo.gaydazhiev@redis.com> (cherry picked from commit e7bf717)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4330