Skip to content

Conversation

@whawker
Copy link
Collaborator

@whawker whawker commented Nov 7, 2023

Description

This ensures we transform class properties etc

Checklist

  • I have read the contributing document.
  • My code follows the code style of this project and pnpm fix completed successfully.
  • I have updated the documentation where necessary.
  • New code is unit tested and all current tests pass when running pnpm test.

@whawker whawker requested a review from ocavue November 7, 2023 22:24
@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2023

🦋 Changeset detected

Latest commit: 356e215

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 77 packages
Name Type
@remirror/core Patch
jest-remirror Patch
remirror Patch
@remirror/dom Patch
@remirror/extension-annotation Patch
@remirror/extension-bidi Patch
@remirror/extension-blockquote Patch
@remirror/extension-bold Patch
@remirror/extension-callout Patch
@remirror/extension-code-block Patch
@remirror/extension-code Patch
@remirror/extension-codemirror5 Patch
@remirror/extension-codemirror6 Patch
@remirror/extension-collaboration Patch
@remirror/extension-columns Patch
@remirror/extension-count Patch
@remirror/extension-diff Patch
@remirror/extension-doc Patch
@remirror/extension-drop-cursor Patch
@remirror/extension-embed Patch
@remirror/extension-emoji Patch
@remirror/extension-entity-reference Patch
@remirror/extension-epic-mode Patch
@remirror/extension-events Patch
@remirror/extension-file Patch
@remirror/extension-find Patch
@remirror/extension-font-family Patch
@remirror/extension-font-size Patch
@remirror/extension-gap-cursor Patch
@remirror/extension-hard-break Patch
@remirror/extension-heading Patch
@remirror/extension-history Patch
@remirror/extension-horizontal-rule Patch
@remirror/extension-image Patch
@remirror/extension-italic Patch
@remirror/extension-link Patch
@remirror/extension-list Patch
@remirror/extension-markdown Patch
@remirror/extension-mention-atom Patch
@remirror/extension-mention Patch
@remirror/extension-node-formatting Patch
@remirror/extension-paragraph Patch
@remirror/extension-placeholder Patch
@remirror/extension-positioner Patch
@remirror/extension-react-component Patch
@remirror/extension-react-language-select Patch
@remirror/extension-react-ssr Patch
@remirror/extension-react-tables Patch
@remirror/extension-search Patch
@remirror/extension-shortcuts Patch
@remirror/extension-strike Patch
@remirror/extension-sub Patch
@remirror/extension-sup Patch
@remirror/extension-tables Patch
@remirror/extension-text-case Patch
@remirror/extension-text-color Patch
@remirror/extension-text-highlight Patch
@remirror/extension-text Patch
@remirror/extension-trailing-node Patch
@remirror/extension-underline Patch
@remirror/extension-whitespace Patch
@remirror/extension-yjs Patch
@remirror/preset-core Patch
@remirror/preset-formatting Patch
@remirror/preset-react Patch
@remirror/preset-wysiwyg Patch
@remirror/react-components Patch
@remirror/react-core Patch
@remirror/react-hooks Patch
@remirror/react-renderer Patch
@remirror/react-ssr Patch
@remirror/react-ui Patch
@remirror/extension-template Patch
@remirror/preset-template Patch
@remirror/react-editors Patch
@remirror/react Patch
@remirror/dev Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added package: @remirror/cli 📟 A label for the remirror cli. type: changeset 🦋 A change has been made to the changesets folder. labels Nov 7, 2023
targets: {
node: '14',
// See https://remirror.io/docs/advanced/browser-support
browsers: 'since 2017',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocavue This hasn't been changed in a while, perhaps we could update this to since 2019 or something?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a s strong opinion of it. I think it's ok if you didn't see any issues with your project.

Copy link
Member

@ocavue ocavue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whawker whawker merged commit 46e903e into v3 Nov 8, 2023
@whawker whawker deleted the fix/browser-support branch November 8, 2023 09:05
whawker added a commit that referenced this pull request Jul 30, 2024
* feat(core): decouple Lingui from core, move into optional `@remirror/i18n` (#2128)

* fix(react-components): remove unnecessary dependency from @remirror/react-components

* BREAKING: decouple Lingui from core, move into optional @remirror/i18n

* feat(messages): extract the messages into JSON files

* docs(storybook): add examples using different i18n libraries

* fix: try to resolve isExternal error

* fix: remove @lingui/core from @remirror/messages

* fix: remove @remirror/i18n from @remirror/react-core

* test(react-core): ensure the i18nFormat function is provided by hook

* fix: revert lingui extract to be done from the root folder

* docs(core-types): add descriptions for the new types

* chore: update changeset

* feat: use stage-3 ES decorator (#2166)

* chore: run pnpm fix

* chore: enter v3 beta release

* chore: fix cyclic dependency (#2168)

* chore: skip storybook-react when building packages

* chore(ci): enable turbo remote cache (#2171)

* chore: clean changeset

* chore: update .eslintignore

* chore(changeset): version update (beta) (#2170)

* chore(ci): try to fix ci test

* chore: cache more output files

* chore: build jest-prosemirror

* chore: increase size-limit

* chore: run pnpm dedupe

* chore: build testing

* chore: fix test

* chore(ci): increase timeout-minutes

* chore: run pnpm fix

* chore: fix publish-v3 name

* chore: set publish branch to v3

* chore: fix the build script for @remirror/messages and @remirror/theme

* chore: fix the build script for @remirror/react

* chore: add script `build:packages:force`

* fix(pm): update ProseMirror dependencies to latest versions (#2192)

* feat(mention-atom): add leaf text for mention atom nodes (#2190)

* chore: fix `watch:skip-build` script

* feat: extract MUI react components into `@remirror/react-ui` (#2193)

* feat: extract MUI react components into a new optional package `@remirror/react-ui`

* docs: add custom mui theme example

* feat: make `extension` decorator backwards compatible when called as function (#2191)

* chore(core): remove deprecated extensionDecorator

* fix(core): make extension decorator backward compatible (when called as function)

* docs: tidy up (#2196)

* docs: remove beta notice from file extension

* fix: remove incorrect usage statement from `@remirror/react-ui` readme

* docs: add orphaned extension docs to the index page

* chore(changeset): version update (beta) (#2194)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: downgrade build target (#2197)

* chore: downgrade build target

* chore(changeset): version update (beta) (#2198)

* chore: downgrade build target to support browsers since 2017 (#2199)

* chore: downgrade build target to support browsers since 2017

* fix: increase size limit on some packages

* chore(changeset): version update (beta) (#2200)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix: bump all packages to rebuild for browsers since 2017 (#2201)

* chore(changeset): version update (beta) (#2202)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: remove deprecated items (#2208)

* chore(theme): remove deprecated functions

* chore(types): remove deprecated types

* chore(jest-remirror): remove deprecated start and end values

* chore(jest-prosemirror): remove deprecated jumpTo function

* chore(core-constants): remove deprecated error code

* chore(core): remove deprecated `getRemirrorJSON` helper

* chore: remove deprecated `isEnabled` command helper

* chore(events): remove deprecated types

* chore(react-hooks): remove deprecated useSuggester alias

* fix: reorganise changeset severity

* fix(react-ui): language selector should be a component, not an extension (#2203)

* fix(react-ui): language selector should be a component, not an extension

* feat(find): remove deprecated `SearchExtension`, add `FindButton` component (#2213)

* feat(preset-wysiwyg): remove deprecated search extension, replace with find extension

* feat(react-ui): add find button and ability to toggle replace

* chore(changeset): version update (beta) (#2210)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Merge remote-tracking branch 'origin/main' into v3

* fix: bump to an version of esbuild that supports decorators

* chore: add changeset

* chore: bump all packages for next beta

* fix: audit errors

* fix: actually fix audit error

* fix: run pnpm fix

* fix: support older environments

* fix: override typescript version used in build

* chore: add satisfies to custom extension docs

* fix: update formatjs version to trigger typescript change

* chore: try to specific typescript version in cli

* fix: output type definitions correctly

* chore(changeset): version update (beta) (#2271)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: forward-port validate property removal

* chore(changeset): version update (beta) (#2274)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: remove React Tables extension from `@remirror/react`

* chore: remove YjsExtension from `remirror/extensions`

* chore: remove CodemirrorExtension from `remirror/extensions`

* fix: missing tsconfig reference

* chore: export cx from core-helpers using clsx

* fix: actually fix tsconfig for markdown ext

* chore(changeset): version update (beta) (#2276)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* feat: upgrade to prettier v3.2 (#2255)

* feat: Upgrade to prettier v3.2

* (Revisions) feat: Upgrade to prettier v3.2

- Extract code language string to parser name identification into its
  own function.

* (Revisions) feat: Upgrade to prettier v3.2

- Use DelayedCommand to generate command formatCodeBlock and make the
  command generator available via the extension store.
- Refactor formatCodeBlockFactory into formatCode that only returns
  information about document updates to be applied instead of also
  dispatching transactions itself.

* (Revisions) feat: Upgrade to prettier v3.2

- Revisions from review

* fix: formatCodeBlock cannot be chained

* test: use exposed formatter in unit tests

* chore: update changeset

* test: use a more realistic custom formatter

---------

Co-authored-by: William Hawker <w.hawker@hotmail.co.uk>

* fix: update loglevel arg in helper script (#2278)

* feat: add code block formatter to react-ui (#2256)

* feat: add code formatter button extension

* feat: add button for code block formatting 

Introduce CodeBlockTools component in react-ui that positions components
with a code block

Introduce a CodeBlockFormatButton component that formats code blocks
using the provided formatter

---------

Co-authored-by: William Hawker <w.hawker@hotmail.co.uk>

* chore: switch to release candidate builds

* chore(changeset): version update (rc) (#2277)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix: do not exit formatting if `onClick` provided

* chore: update styled-components to v6 (#2280)

* chore: update styled-components to v6

- styled-components is a peer dependency, so other projects rely on
  remirror keeping it up to date or they can be blocked from updating it
  themselves (without overrides); bump to v6.
- Remove @types/styled-components since types are bundled with v6.

Fixes #2279

* fix: remove incorrect type declarations from styles

While typing exported variables is generally good practice, the types
applied to style constants were nothing more than an attempt to derive
the return type of the function being called, and they were incorrect.
Assign the values and let the type inference do its magic.

Fix the order of imports in styled-components.tsx so that when the file
is regenerated its imports agree with lint rules.

---------

Co-authored-by: William Hawker <w.hawker@hotmail.co.uk>

* chore: exit pre-release mode

* chore: remove references to obsolete extensions

---------

Co-authored-by: ocavue <ocavue@gmail.com>
Co-authored-by: William Hawker <w.hawker@hotmail.co.uk>
Co-authored-by: Matt Mower <mdmower@cmphys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: @remirror/cli 📟 A label for the remirror cli. type: changeset 🦋 A change has been made to the changesets folder.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants