tidy: make rustc dependency error less confusing#102468
tidy: make rustc dependency error less confusing#102468bors merged 2 commits intorust-lang:masterfrom
Conversation
|
r? @jyn514 (rust-highfive has picked a reviewer for you, use r? to override) |
|
(FWIW, the function names here are not very helpful. |
This doesn't match my reading of the code. It runs |
|
Yeah I had to read the code 3 times to figure out what happens. It only checks the dependencies of |
|
The new names make the code a lot easier to understand, thanks :) @bors r+ rollup |
tidy: make rustc dependency error less confusing The current wording leads to very confusing messages: ``` tidy error: Dependencies for main workspace not explicitly permitted: * unicode-ident 1.0.4 (registry+https://github.com/rust-lang/crates.io-index) ``` Miri is part of that workspace, and there never was a problem adding Miri dependencies. The actual error is that due to a crate bump this now showed up as a rustc dependency, and *those* are restricted.
Rollup of 7 pull requests Successful merges: - rust-lang#102214 (Fix span of byte-escaped left format args brace) - rust-lang#102426 (Don't export `__wasm_init_memory` on WebAssembly.) - rust-lang#102437 (rustdoc: cut margin-top from first header in docblock) - rust-lang#102442 (rustdoc: remove bad CSS font-weight on `.impl`, `.method`, etc) - rust-lang#102447 (rustdoc: add method spacing to trait methods) - rust-lang#102468 (tidy: make rustc dependency error less confusing) - rust-lang#102476 (Split out the error reporting logic into a separate function) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
The current wording leads to very confusing messages:
Miri is part of that workspace, and there never was a problem adding Miri dependencies. The actual error is that due to a crate bump this now showed up as a rustc dependency, and those are restricted.