Skip to content
This repository was archived by the owner on Apr 18, 2026. It is now read-only.

Fixed incorrect highlighting of options that were activated, removed and then re-added in "multiple" mode#1420

Merged
risadams merged 2 commits into
selectize:masterfrom
sustmi:fix-removing-active
Oct 18, 2022
Merged

Fixed incorrect highlighting of options that were activated, removed and then re-added in "multiple" mode#1420
risadams merged 2 commits into
selectize:masterfrom
sustmi:fix-removing-active

Conversation

@sustmi

@sustmi sustmi commented Jun 20, 2018

Copy link
Copy Markdown
Contributor

This PR fixes the following issues:

The incorrect behavior can be seen in the following screen-capture:
selectize

Also, here is a codepen: https://codepen.io/anon/pen/ERENZB .

After this fix, the re-added options are not highlighted anymore.

michael-maltsev pushed a commit to michael-maltsev/selectize.js that referenced this pull request Aug 28, 2018
@sustmi sustmi force-pushed the fix-removing-active branch from f25fba1 to 7ac5e6f Compare November 12, 2018 13:14
@sustmi sustmi force-pushed the fix-removing-active branch from 7ac5e6f to 18809a9 Compare November 12, 2018 13:18
@sustmi

sustmi commented Nov 12, 2018

Copy link
Copy Markdown
Contributor Author

I rebased the code on the current master and resolved the conflicts.

@github-actions

github-actions Bot commented Jan 1, 2021

Copy link
Copy Markdown
Contributor

Stale pull request message

@caseyjhol

Copy link
Copy Markdown

@risadams May want to consider merging this?

@risadams risadams reopened this Dec 7, 2021
@risadams risadams added pending review This issue was closed as stale; since then additional review has been requested. and removed no-pr-activity labels Dec 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

hacktoberfest-accepted pending review This issue was closed as stale; since then additional review has been requested.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants