Fixed backward compatibility test #6564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aylei <rayingecho@gmail.com>
Collaborator
Author
|
/quicktest-core |
Collaborator
|
/quicktest-core --base-branch releases/0.9.3 |
Collaborator
Author
|
/quicktest-core --base-branch releases/0.9.3 |
kevinmingtarja
approved these changes
Aug 7, 2025
Collaborator
kevinmingtarja
left a comment
There was a problem hiding this comment.
Thanks for fixing @aylei! Sorry for breaking this on my last PR.
LGTM, there's just one place where it needs to be reverted to --cloud again. I think the test should pass after that.
Collaborator
|
/quicktest-core --base-branch releases/0.9.3 |
lloyd-brown
pushed a commit
that referenced
this pull request
Aug 8, 2025
* Fixed backward compatibility test Signed-off-by: Aylei <rayingecho@gmail.com> * Fix Signed-off-by: Aylei <rayingecho@gmail.com> * Update tests/smoke_tests/backward_compat/test_backward_compat.py --------- Signed-off-by: Aylei <rayingecho@gmail.com> Co-authored-by: Kevin Mingtarja <69668484+kevinmingtarja@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the compatibility test runs agains v0.9.3
Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)