[Serve] Skip core.down on failed replica records
#6580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
/smoke-test --serve |
cg505
approved these changes
Aug 12, 2025
Collaborator
cg505
left a comment
There was a problem hiding this comment.
Is there any chance this runs at the same time as launch is still happening for the cluster? If yes we need to resolve that I think. If no, this should be good, left a minor comment.
| replica_infos = serve_state.get_replica_infos(service_name) | ||
| info2proc: Dict[replica_managers.ReplicaInfo, | ||
| multiprocessing.Process] = dict() | ||
| # NOTE(dev): This relies on `sky/serve/serve_utils.py:: |
Collaborator
There was a problem hiding this comment.
Can you add a note in sky/serve/serve_utils pointing to this code as well?
Collaborator
Author
No, as we will kill every children process before we calling this function: Lines 338 to 340 in 7af64d7 |
massaindustries
pushed a commit
to Seeweb/skypilot
that referenced
this pull request
Aug 26, 2025
* limit * comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)