Reduce occurance of import sky #6641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks @SeungjinYang! Do we know much performance improvement for importing sky? |
Collaborator
Author
|
Sadly there is actually zero perf improvement for avoiding sky import, because importing modules like |
Collaborator
Author
|
/quicktest-core |
Collaborator
Author
|
/smoke-test |
Michaelvll
approved these changes
Aug 13, 2025
massaindustries
pushed a commit
to Seeweb/skypilot
that referenced
this pull request
Aug 26, 2025
* init * additional * task_lib * registries * more fixes * undo admin policy * testfix attempt * textfix2 * remove import sky even in typechecking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import skystatement in internal code imports a lot of (unnecessary) things at once, causing unnecessary circular import issues and overall making the codepath slower. Reduce the occurrence ofimport skystatements by importing more targeted modules whenever possible.Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)