[sdk] better type definition for status response #6659
Conversation
|
/quicktest-core |
1 similar comment
|
/quicktest-core |
|
/smoke-test |
|
/quicktest-core |
|
/smoke-test |
3 similar comments
|
/smoke-test |
|
/smoke-test |
|
/smoke-test |
|
/quicktest-core |
rohansonecha
left a comment
There was a problem hiding this comment.
This definitely looks like progress @SeungjinYang! Left a couple of questions. Also, I see you mentioned that pydantic cannot generate pydantic-core schemas for handle and storage_mounts_metadata. Do you have any ideas as to how we can address this in the future?
Unfortunately not as of now sadly, at least without breaking backwards compatibility. This is something we may need to address in SDK v2 if / when that happens. |
|
/quicktest-core |
|
/smoke-test |
|
/quicktest-core -k sdk |
|
/quicktest-core |
rohansonecha
left a comment
There was a problem hiding this comment.
This LGTM pending tests passing. Thank you for adding the comments explaining the remaining Any types @SeungjinYang!
* init * idk * this works?" * works? * format * fix serializer * add workspaces * all the fields * yayay * last event optional str * wow * str-cpus * optional last creation cmd * optional is None * ??? * finalize schema * json * dict repr
Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)