Handle case where cluster is already terminated during status refresh #6693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ely_autostopping()
Collaborator
Author
|
/smoke-test -k test_autodown |
Collaborator
Author
|
/quicktest-core |
Collaborator
Author
|
/smoke-test -k test_autodown --gcp |
Collaborator
Author
|
/smoke-test -k test_autodown --kubernetes |
Collaborator
Author
|
/smoke-test -k test_autodown |
SeungjinYang
approved these changes
Aug 15, 2025
massaindustries
pushed a commit
to Seeweb/skypilot
that referenced
this pull request
Aug 26, 2025
…skypilot-org#6693) * handle case where the cluster is already terminated during is_definitely_autostopping() * handle in one more place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes https://buildkite.com/skypilot-1/smoke-tests/builds/2430/steps/canvas?jid=0198a7f9-1fbf-49c2-874f-6614e854648d, together with #6697.
During status refresh (which also gets called during
sky down), we may callbackend.is_definitely_autostopping(). At this point, the cluster might already be terminating/terminated, causing this call to fail. After moving the autostop to gRPC in #6574, we missed adding a try catch block to the gRPC call, so instead of returning False, we bubble up the gRPC timeout exception.This PR fixes it by returning False from this function when encountering an exception, which is the same behaviour in the legacy SSH execution, returning False if exit code != 0.
Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)