Skip to content

Conversation

@DanielZhangQD
Copy link
Collaborator

@DanielZhangQD DanielZhangQD commented Aug 20, 2025

Skip applying volume policy to job/serve controller

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • Launch a cluster with volume admin policy enabled, volumes are updated
    • Launch a managed job with volume admin policy enabled, volumes are updated to the job cluster but not to the job controller
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

@DanielZhangQD DanielZhangQD requested a review from aylei August 20, 2025 11:52
@DanielZhangQD DanielZhangQD marked this pull request as ready for review August 20, 2025 11:52
Copy link
Collaborator

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD DanielZhangQD merged commit be7e9d9 into master Aug 20, 2025
16 checks passed
@DanielZhangQD DanielZhangQD deleted the 2955 branch August 20, 2025 12:14
massaindustries pushed a commit to Seeweb/skypilot that referenced this pull request Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants