[Pool][Serve] Resource management coordination for jobs/pool; Move to SDK + Threading for SkyServe provision/terminate. #7332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
/smoke-test |
Collaborator
Author
|
/quicktest-core |
Collaborator
Author
|
/smoke-test |
Collaborator
Author
|
/quicktest-core |
Collaborator
Author
|
also cc @andylizf who proposed this change (using thread) a while ago |
Collaborator
|
@cblmemo My static type checker gives [{
"resource": "/home/andyl/skypilot/sky/jobs/controller.py",
"owner": "pyright",
"severity": 8,
"message": "\"LAUNCHES_PER_WORKER\" is not a known attribute of module \"sky.jobs.scheduler\"",
"startLineNumber": 1122,
"startColumn": 44,
"endLineNumber": 1122,
"endColumn": 63,
"modelVersionId": 3
}] |
Collaborator
Author
|
/smoke-test |
Collaborator
Author
|
/smoke-test |
Collaborator
Author
|
/smoke-test |
Collaborator
Author
|
/smoke-test |
andylizf
requested changes
Sep 25, 2025
Collaborator
andylizf
left a comment
There was a problem hiding this comment.
Left some discussions.
Co-authored-by: Andy Lee <andylizf@outlook.com>
Collaborator
Author
|
/smoke-test -k new_autoscaler_update --gcp |
Collaborator
Author
|
/smoke-test --serve -k autoscaler |
Collaborator
Author
|
/smoke-test --serve |
Collaborator
Author
|
/smoke-test |
Collaborator
Author
|
/smoke-test --serve -k autoscaler |
Collaborator
Author
|
/smoke-test --serve -k autoscaler |
Collaborator
Author
|
/smoke-test --serve |
This reverts commit 8c607d2.
Collaborator
Author
|
/smoke-test --serve -k autoscaler |
cg505
approved these changes
Nov 22, 2025
sky/skylet/constants.py
Outdated
| OVERRIDE_CONSOLIDATION_MODE = 'IS_SKYPILOT_JOB_CONTROLLER' | ||
| IS_SKYPILOT_SERVE_CONTROLLER = 'IS_SKYPILOT_SERVE_CONTROLLER' | ||
|
|
||
| OVERRIDE_CONCURRENT_LAUNCHES = 'OVERRIDE_CONCURRENT_LAUNCHES' |
Collaborator
There was a problem hiding this comment.
Can we rename the env var to SKYPILOT_SERVE_OVERRIDE_CONCURRENT_LAUNCHES?
Collaborator
Author
|
/smoke-test --serve -k autoscaler |
Collaborator
Author
|
/smoke-test --serve |
andylizf
approved these changes
Nov 23, 2025
Collaborator
Author
|
All test passed. Merging now! |
cg505
added a commit
to cg505/skypilot
that referenced
this pull request
Nov 25, 2025
This causes issues with sdk usage, which may invoke the client multiple times with different env vars within the same process. Correctness here is worth the miniscule performance hit. This fixes the smoke test `test_managed_jobs_config_labels_isolation`. That test technically regressed in skypilot-org#7966, but would only fail when both jobs were claimed by the same job controller process, which is rare. After skypilot-org#7332, the test would only have a single job controller process and started consistently failing.
5 tasks
5 tasks
cg505
added a commit
that referenced
this pull request
Nov 26, 2025
* [client] remove client-side cache for request payload env vars This causes issues with sdk usage, which may invoke the client multiple times with different env vars within the same process. Correctness here is worth the miniscule performance hit. This fixes the smoke test `test_managed_jobs_config_labels_isolation`. That test technically regressed in #7966, but would only fail when both jobs were claimed by the same job controller process, which is rare. After #7332, the test would only have a single job controller process and started consistently failing. * fix test
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the resource management for both pool/serve and jobs controllers.
Rules:
MAXIMUM_CONTROLLER_RESERVED_MEMORY_MB, and the remaining resources is dedicated to the API server;POOL_JOBS_RESOURCES_RATIO.This PR also move SkyServe's process-based launch/termination into API Server calls and using threads.
Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)