Skip to content

Conversation

@marcwrobel
Copy link
Contributor

@marcwrobel marcwrobel commented Jul 27, 2022

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 27, 2022
@marcwrobel
Copy link
Contributor Author

I also found the following broken links but I am not sure what to do with them :

Maybe the corresponding entry should be deleted from the Starters list ?

@snicoll
Copy link
Member

snicoll commented Jul 27, 2022

Thanks again @marcwrobel. Regarding your comment for the starters, see #31889 and #31892


| https://logback.qos.ch/access.html[Logback-access]
| https://github.com/akihyro/logback-access-spring-boot-starter
| https://github.com/akkinoc/logback-access-spring-boot-starter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any relationship between akihyro's starter and akkinoc's starter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@akkinoc akkinoc Jul 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the link!
I changed my GitHub username from akihyro to akkinoc a few years ago.
akihyro and akkinoc are the same person.
For some reason GitHub redirects aren't working, but the two repositories are the same.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @akkinoc.

- fix broken links (using their new URL, an alternative URL or a Wayback Machine link),
- use HTTPS where possible,
- remove spring-security-oauth2-docs : this link is not used anymore,
- remove https://github.com/ThierrySquirrel/rocketmq-spring-boot-starter, this starter is 404 and https://github.com/rocketmq/rocketmq-spring-boot-starter hasn't been updated for 4 years.
- cleanup nohttp allowlist.lines.
@wilkinsona wilkinsona added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 1, 2022
@wilkinsona wilkinsona added this to the 2.6.x milestone Aug 1, 2022
@wilkinsona wilkinsona modified the milestones: 2.6.x, 2.6.11 Aug 1, 2022
wilkinsona pushed a commit that referenced this pull request Aug 1, 2022
- Fix broken links
- Use HTTPS where possible,
- Remove spring-security-oauth2-docs as it is no longer used
- Remove https://github.com/ThierrySquirrel/rocketmq-spring-boot-starter.
  This starter is 404 and https://github.com/rocketmq/rocketmq-spring-boot-starter
  hasn't been updated for 4 years.
- Clean up nohttp allowlist.lines.

See gh-31887
@wilkinsona wilkinsona closed this in d69fcf8 Aug 1, 2022
@wilkinsona
Copy link
Member

Thanks very much, @marcwrobel.

@marcwrobel marcwrobel deleted the fix-links branch August 1, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: documentation A documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants