-
Notifications
You must be signed in to change notification settings - Fork 41.8k
Fix links in documentations #31887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix links in documentations #31887
Conversation
|
I also found the following broken links but I am not sure what to do with them :
Maybe the corresponding entry should be deleted from the Starters list ? |
|
Thanks again @marcwrobel. Regarding your comment for the starters, see #31889 and #31892 |
|
|
||
| | https://logback.qos.ch/access.html[Logback-access] | ||
| | https://github.com/akihyro/logback-access-spring-boot-starter | ||
| | https://github.com/akkinoc/logback-access-spring-boot-starter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any relationship between akihyro's starter and akkinoc's starter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not really know, but older commits are from Akihiro Kondo (https://github.com/akkinoc/logback-access-spring-boot-starter/commits/main?after=570258387eb0f5dec348f1b0df505a67a890b5cc+314&branch=main&qualified_name=refs%2Fheads%2Fmain), it is active (https://github.com/akkinoc/logback-access-spring-boot-starter/pulse), up-to-date and popular.
Maybe you should check with @akkinoc ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing the link!
I changed my GitHub username from akihyro to akkinoc a few years ago.
akihyro and akkinoc are the same person.
For some reason GitHub redirects aren't working, but the two repositories are the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @akkinoc.
- fix broken links (using their new URL, an alternative URL or a Wayback Machine link), - use HTTPS where possible, - remove spring-security-oauth2-docs : this link is not used anymore, - remove https://github.com/ThierrySquirrel/rocketmq-spring-boot-starter, this starter is 404 and https://github.com/rocketmq/rocketmq-spring-boot-starter hasn't been updated for 4 years. - cleanup nohttp allowlist.lines.
- Fix broken links - Use HTTPS where possible, - Remove spring-security-oauth2-docs as it is no longer used - Remove https://github.com/ThierrySquirrel/rocketmq-spring-boot-starter. This starter is 404 and https://github.com/rocketmq/rocketmq-spring-boot-starter hasn't been updated for 4 years. - Clean up nohttp allowlist.lines. See gh-31887
|
Thanks very much, @marcwrobel. |
Uh oh!
There was an error while loading. Please reload this page.