Skip to content

test: enable previously filtered test cases and update expected outputs #12396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LingyuCoder merged 2 commits into from
Dec 9, 2025
Merged

test: enable previously filtered test cases and update expected outputs #12396

LingyuCoder merged 2 commits into from
Dec 9, 2025

Conversation

@LingyuCoder
Copy link
Contributor

@LingyuCoder LingyuCoder commented Dec 9, 2025

Summary

This PR enables several test cases that were previously filtered out by removing their test.filter.js files. Additionally, it updates the expected outputs for some diagnostic tests to match the improved error message formatting.

Changes:

  • Removed test.filter.js files to enable previously skipped tests
  • Updated expected error outputs to reflect more detailed diagnostic messages
  • Fixed test expectations for lazy compilation and banner plugin tests

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings December 9, 2025 09:25
@netlify
Copy link

netlify bot commented Dec 9, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit ea105c2
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/6937f1d343f6490008bc33fe

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Dec 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025 •
edited
Loading

📦 Binary Size-limit

Comparing ea105c2 to fix: add test/include/exclude options to EvalSourceMapDevToolPlugin (#12392) by harpsealjs

🙈 Size remains the same at 47.71MB

Copilot AI reviewed Dec 9, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables several previously filtered test cases and updates expected outputs to align with improved error message formatting in the rspack build system. The changes focus on test infrastructure improvements and modernization.

  • Removed test.filter.js files that were skipping tests across watchCases, hotCases, configCases, and diagnosticsCases
  • Updated banner plugin tests to use globalThis instead of global for better cross-environment compatibility
  • Updated diagnostic test expectations to reflect enhanced error messages with source code context and location information

Reviewed changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/rspack-test/watchCases/resolve/in-loader/test.filter.js Removed test filter to enable the test
tests/rspack-test/hotCases/plugins/banner/test.filter.js Removed test filter to enable the banner plugin test
tests/rspack-test/hotCases/plugins/banner/rspack.config.js Updated banner to use globalThis instead of global
tests/rspack-test/hotCases/plugins/banner/index.js Updated test assertions to use globalThis instead of global
tests/rspack-test/hotCases/loader-import-module/css/test.filter.js Removed test filter to enable the test
tests/rspack-test/hotCases/lazy-compilation/simple/test.filter.js Changed from skipping test to expecting specific error message format
tests/rspack-test/diagnosticsCases/factorize/export_star_error/test.filter.js Removed test filter to enable the diagnostic test
tests/rspack-test/diagnosticsCases/factorize/export_star_error/stats.err Updated to reflect new detailed error format with source context
tests/rspack-test/diagnosticsCases/factorize/export_star_error/rspack.config.js Simplified configuration by removing DefinePlugin
tests/rspack-test/diagnosticsCases/factorize/export_star_error/raw-warning.err Added expected raw warning output with location information
tests/rspack-test/diagnosticsCases/factorize/export_star_error/raw-error.err Added expected raw error output (empty array)
tests/rspack-test/configCases/types/filesystems/test.filter.js Removed test filter to enable the filesystems type test
tests/rspack-test/configCases/target/system-named-assets-path/test.filter.js Removed test filter to enable the test
tests/rspack-test/configCases/parsing/require-ignore/test.filter.js Removed test filter to enable the test
tests/rspack-test/configCases/module/dependOn-entries/test.filter.js Removed test filter to enable the test
tests/rspack-test/configCases/mangle/exports-info-can-mangle/test.filter.js Removed test filter to enable the test
tests/rspack-test/configCases/library/module-reexport-external/test.filter.js Removed test filter to enable the test
tests/rspack-test/configCases/errors/generator-generate-error/test.filter.js Removed test filter to enable the test

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025 •
edited
Loading

Rsdoctor Bundle Diff Analysis

Found 5 project(s) in monorepo.

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

📌 Baseline Commit: f375692ed8 | PR: #12392

Metric Current Baseline Change
📊 Total Size 5.7 MB 5.7 MB 0 B (0.0%)
📄 JavaScript 5.7 MB 5.7 MB 0 B (0.0%)
🎨 CSS 21.0 B 21.0 B 0 B (0.0%)
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: react-10k Bundle Diff

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

📌 Baseline Commit: f375692ed8 | PR: #12392

Metric Current Baseline Change
📊 Total Size 823.6 KB 823.6 KB 0 B (0.0%)
📄 JavaScript 823.6 KB 823.6 KB 0 B (0.0%)
🎨 CSS 0 B 0 B N/A
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: react-1k Bundle Diff

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

📌 Baseline Commit: f375692ed8 | PR: #12392

Metric Current Baseline Change
📊 Total Size 2.7 MB 2.7 MB 0 B (0.0%)
📄 JavaScript 2.7 MB 2.7 MB 0 B (0.0%)
🎨 CSS 21.0 B 21.0 B 0 B (0.0%)
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: react-5k Bundle Diff

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

📌 Baseline Commit: f375692ed8 | PR: #12392

Metric Current Baseline Change
📊 Total Size 984.3 KB 984.3 KB 0 B (0.0%)
📄 JavaScript 984.3 KB 984.3 KB 0 B (0.0%)
🎨 CSS 0 B 0 B N/A
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: rome Bundle Diff

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

📌 Baseline Commit: f375692ed8 | PR: #12392

Metric Current Baseline Change
📊 Total Size 2.1 MB 2.1 MB -13.3 KB (-0.6%)
📄 JavaScript 2.0 MB 2.0 MB -13.3 KB (-0.6%)
🎨 CSS 83.0 KB 83.0 KB 0 B (0.0%)
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: ui-components Bundle Diff

Generated by Rsdoctor GitHub Action

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 9, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #12396 will not alter performance

Comparing test/enable-filtered-tests (ea105c2) with main (f375692)

Summary

✅ 17 untouched

@LingyuCoder LingyuCoder requested a review from 9aoy December 9, 2025 10:18
@LingyuCoder LingyuCoder merged commit 436b4db into main Dec 9, 2025
76 of 78 checks passed
@LingyuCoder LingyuCoder deleted the test/enable-filtered-tests branch December 9, 2025 10:40
@CPunisher CPunisher mentioned this pull request Dec 17, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@9aoy 9aoy 9aoy approved these changes

Assignees

No one assigned

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LingyuCoder @9aoy