Skip to content

chore(ci): run Mac CI test on github hosted runner #12397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stormslowly merged 1 commit into from
Dec 9, 2025
Merged

chore(ci): run Mac CI test on github hosted runner #12397

stormslowly merged 1 commit into from
Dec 9, 2025

Conversation

@stormslowly
Copy link
Contributor

@stormslowly stormslowly commented Dec 9, 2025

Summary

NativeWatch fails more frequently on self hosted runner.

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings December 9, 2025 10:33
@netlify
Copy link

netlify bot commented Dec 9, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit a60b487
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/6937fb06d4cbf200087891fa

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Dec 9, 2025
Copilot AI reviewed Dec 9, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses reliability issues with NativeWatch tests on Mac by separating the build and test runners. The Mac CI job will now use GitHub-hosted runners (macos-latest) for running tests while continuing to use self-hosted runners (when available) for building. This follows the same pattern already established for Windows tests.

  • Adds test-runner parameter to the test-mac job configuration
  • Aligns Mac CI behavior with Windows CI, which already uses separate runners for testing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Rsdoctor Bundle Diff Analysis

Found 5 project(s) in monorepo.

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 5.7 MB - -
📄 JavaScript 5.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 823.6 KB - -
📄 JavaScript 823.6 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.7 MB - -
📄 JavaScript 2.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 984.3 KB - -
📄 JavaScript 984.3 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.1 MB - -
📄 JavaScript 2.0 MB - -
🎨 CSS 83.0 KB - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

📦 Binary Size-limit

Comparing a60b487 to chore: release v1.6.7 (#12391) by Fy

🙈 Size remains the same at 47.71MB

@stormslowly stormslowly enabled auto-merge (squash) December 9, 2025 10:47
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 9, 2025

CodSpeed Performance Report

Merging #12397 will not alter performance

Comparing chore/mac_test_run_on_github_hosted (a60b487) with main (96e0aa5)

Summary

✅ 17 untouched

@stormslowly stormslowly merged commit 80c4537 into main Dec 9, 2025
61 checks passed
@stormslowly stormslowly deleted the chore/mac_test_run_on_github_hosted branch December 9, 2025 10:50
This was referenced Dec 9, 2025
Merged
Merged
Merged
@CPunisher CPunisher mentioned this pull request Dec 17, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@LingyuCoder LingyuCoder LingyuCoder approved these changes

Assignees

No one assigned

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stormslowly @LingyuCoder