fix: relative-resource-path should handle output.filename #12398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
Contributor
|
📝 Benchmark detail: Open task failure |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the handling of output.filename placeholders in source map generation when using the [relative-resource-path] template. Previously, the source map path resolution didn't account for subdirectories in the output filename (e.g., static/js/[name].js), resulting in incorrect source map file paths.
Key Changes:
- Modified
get_unresolved_source_map_pathto resolve the source map filename template with the actual asset filename, ensuring source maps are placed in the correct directory structure - Changed the function from synchronous to asynchronous to support template rendering
- Updated test configuration to verify the fix works with nested output paths
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
crates/rspack_plugin_devtool/src/source_map_dev_tool_plugin.rs |
Updated get_unresolved_source_map_path to accept asset filename and render templates, converting from sync to async function |
tests/rspack-test/configCases/source-map/relative-resource-path/rspack.config.js |
Added filename: 'static/js/[name].js' to test nested output paths and updated source map path expectation |
tests/rspack-test/configCases/source-map/relative-resource-path/test.config.js |
Added findBundle configuration to locate the generated bundle in the nested directory structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Rsdoctor Bundle Diff AnalysisFound 5 project(s) in monorepo. 📁 react-10kPath:
📁 react-1kPath:
📁 react-5kPath:
📁 ui-componentsPath:
📁 romePath:
Generated by Rsdoctor GitHub Action |
Contributor
📦 Binary Size-limit
❌ Size increased by 1.38KB from 47.71MB to 47.72MB (⬆️0.00%) |
CodSpeed Performance ReportMerging #12398 will not alter performanceComparing Summary
|
Contributor
|
📝 Benchmark detail: Open
|
chenjiahan
previously approved these changes
Dec 9, 2025
chenjiahan
approved these changes
Dec 10, 2025
This was referenced Dec 10, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the handling of
output.filenameplaceholders in source map generation when using the[relative-resource-path]template. Previously, the source map path resolution didn't account for subdirectories in the output filename (e.g.,static/js/[name].js), resulting in incorrect source map file paths.Related links
Checklist