Skip to content

feat(module-federation): enhance manifest generation and shared module handling #12399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahabhgk merged 16 commits into from
Jan 5, 2026
Merged

feat(module-federation): enhance manifest generation and shared module handling #12399

ahabhgk merged 16 commits into from
Jan 5, 2026

Conversation

@2heal1
Copy link
Member

@2heal1 2heal1 commented Dec 9, 2025

Summary

  • Add file field to expose stats for better tracking
  • Improve shared module version and singleton handling with config overrides
  • Support scoped package parsing in shared module identifiers
  • Ensure all configured remotes are included in stats with defaults
  • Strip aggregated module suffixes for cleaner usage tracking
  • Update test cases to verify new functionality

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@2heal1 2heal1 requested a review from ahabhgk as a code owner December 9, 2025 12:48
@netlify
Copy link

netlify bot commented Dec 9, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit fb7d459
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/695b6c73543201000861e08d

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Dec 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025 •
edited
Loading

📦 Binary Size-limit

Comparing fb7d459 to chore: limit workers for loader parallel tests (#12620) by CPunisher

❌ Size increased by 6.88KB from 47.87MB to 47.88MB (⬆️0.01%)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025 •
edited
Loading

Rsdoctor Bundle Diff Analysis

⚠️ Note: The latest commit (cd97e3bb37) does not have baseline artifacts. Using commit 6a1fbdd59c for baseline comparison instead. If this seems incorrect, please wait a few minutes and try rerunning the workflow.

Found 5 projects in monorepo, 0 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB 0
react-5k 2.7 MB 0
react-1k 825.4 KB 0
rome 984.3 KB 0
ui-components 2.1 MB 0

Generated by Rsdoctor GitHub Action

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 9, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #12399 will not alter performance

Comparing fix/mf-manifest (fb7d459) with main (6a1fbdd)1

Summary

✅ 16 untouched
⏩ 1 skipped2

Footnotes

  1. No successful run was found on main (fc645a0) during the generation of this report, so 6a1fbdd was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

@2heal1 2heal1 force-pushed the fix/mf-manifest branch 2 times, most recently from e887c9d to 64b849a Compare December 17, 2025 02:20
ahabhgk
ahabhgk previously approved these changes Dec 18, 2025
View reviewed changes
2heal1 added 12 commits January 5, 2026 10:43
@2heal1
feat(module-federation): enhance manifest generation and shared modul…
2fa9be5 
…e handling

- Add file field to expose stats for better tracking
- Improve shared module version and singleton handling with config overrides
- Support scoped package parsing in shared module identifiers
- Ensure all configured remotes are included in stats with defaults
- Strip aggregated module suffixes for cleaner usage tracking
- Update test cases to verify new functionality
@2heal1
chore: rename react
a0c3fe5
@2heal1
chore: add pkg
9ce4aad
@2heal1
chore: fix lint rs
160fee7
@2heal1
chore: update ut name
2516dae
@2heal1
chore: print res
244e4f9
@2heal1
test: remove redundant assertions in container-1-5 test case
55f4f45
@2heal1
test: remove redundant assertion in container-1-5 test
9e0ff07
@2heal1
test(container): add module import to manifest test case
215b68e 
Add import statement to test module functionality in container scenario
@2heal1
feat(plugin_mf): add support for named chunk assets in manifest
bd55871 
Track named chunks for exposed modules and filter entry assets by name to prevent self-referencing. This improves module federation by ensuring proper asset resolution and avoiding circular dependencies.
@2heal1
fix(module-federation): improve asset collection logic and test cases
bdada77 
- Refactor asset collection to prioritize chunk names over module IDs
- Update test cases to use proper assertions and async imports
- Add runtime plugin configuration for error handling
- Change lazy module export to string type for better testing
@2heal1
refactor(plugin_mf): simplify conditional logic in manifest processing
546beb4 
Use Rust 1.62's if-let chains to flatten nested conditionals and improve readability
@ahabhgk ahabhgk merged commit 02a925c into main Jan 5, 2026
52 checks passed
@ahabhgk ahabhgk deleted the fix/mf-manifest branch January 5, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees

No one assigned

Labels

release: feature release: feature related release(mr only)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@2heal1 @ahabhgk