Skip to content

chore(ci): fix artifact discovery logic in Rsdoctor action #12405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chenjiahan merged 5 commits into from
Dec 11, 2025
Merged

chore(ci): fix artifact discovery logic in Rsdoctor action #12405

chenjiahan merged 5 commits into from
Dec 11, 2025

Conversation

@yifancong
Copy link
Contributor

@yifancong yifancong commented Dec 10, 2025 •
edited
Loading

Summary

This pr is to fix the problem that rspack diff ci can't find baseline.

CI Workflow Update:

  • .github/workflows/ci-diff.yml: Updated the web-infra-dev/rsdoctor-action to commit 3576edf3ddc2c86c9651d4a916fad68013c4d6cd for reporting compressed size.

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Dec 10, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit c967695
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/69393365fefe430008d059f1

@yifancong yifancong changed the title chore(CI): fix the logic of finding artifacts chore: fix the logic of finding artifacts Dec 10, 2025
@yifancong yifancong changed the title chore: fix the logic of finding artifacts chore(ci): fix the logic of finding artifacts Dec 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025 •
edited
Loading

Rsdoctor Bundle Diff Analysis

Found 5 project(s) in monorepo.

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 5.7 MB - -
📄 JavaScript 5.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 823.6 KB - -
📄 JavaScript 823.6 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 984.3 KB - -
📄 JavaScript 984.3 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.7 MB - -
📄 JavaScript 2.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.1 MB - -
📄 JavaScript 2.0 MB - -
🎨 CSS 83.0 KB - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025 •
edited
Loading

📦 Binary Size-limit

Comparing c967695 to fix: should use exported name of the imported module (#12423) by Fy

🎉 Size decreased by 510.25KB from 48.21MB to 47.72MB (⬇️1.03%)

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 10, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #12405 will not alter performance

Comparing chore/fix-diff-action (c967695) with main (4b73bc2)

Summary

✅ 17 untouched

@yifancong yifancong changed the title chore(ci): fix the logic of finding artifacts chore(ci): fix rsdoctor action’s the logic of finding artifacts Dec 10, 2025
@yifancong yifancong changed the title chore(ci): fix rsdoctor action’s the logic of finding artifacts chore(ci): fix logic in rsdoctor action for finding artifacts Dec 10, 2025
@yifancong yifancong marked this pull request as ready for review December 10, 2025 08:49
Copilot AI reviewed Dec 10, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the web-infra-dev/rsdoctor-action GitHub Action to a newer version that includes a fix for logic related to finding artifacts. The change is minimal and focused on ensuring the CI workflow uses an updated version of the action that addresses issues with artifact discovery.

Key Changes:

  • Updated web-infra-dev/rsdoctor-action from commit a92db9e to 3576edf in the CI diff workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chenjiahan chenjiahan changed the title chore(ci): fix logic in rsdoctor action for finding artifacts chore(ci): fix artifact discovery logic in Rsdoctor action Dec 10, 2025
@chenjiahan chenjiahan enabled auto-merge (squash) December 10, 2025 09:01
@chenjiahan chenjiahan merged commit 127d0af into main Dec 11, 2025
93 of 98 checks passed
@chenjiahan chenjiahan deleted the chore/fix-diff-action branch December 11, 2025 14:09
This was referenced Dec 12, 2025
Open
Merged
Draft
Merged
Merged
@CPunisher CPunisher mentioned this pull request Dec 17, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@chenjiahan chenjiahan chenjiahan approved these changes

@stormslowly stormslowly Awaiting requested review from stormslowly stormslowly is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yifancong @chenjiahan