test: enable passing configCases tests and document failures #12412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the test infrastructure by systematically processing configCases test filters. It enables 10 tests that now pass by removing their test.filter.js files, and adds documentation comments to 16 test.filter.js files that still have failing tests to better explain why they fail.
- Enables 10 previously filtered tests that now pass (clean/dry, externals import assertions/attributes, loader/type-module, module/check-defaults, plugins/environment-plugin, and all rule-set tests)
- Documents 16 failing tests with structured comments explaining the specific failure reasons
- Maintains consistent test filtering while improving code documentation and transparency
Reviewed changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 18 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/rspack-test/configCases/utils/lazy-set/test.filter.js | Added documentation explaining LazySet implementation issue |
| tests/rspack-test/configCases/split-chunks/runtime-chunk/test.filter.js | Removed filter - test now passes |
| tests/rspack-test/configCases/split-chunks/no-options/test.filter.js | Added documentation explaining missing splitChunks plugin |
| tests/rspack-test/configCases/split-chunks/entry-point-error/test.filter.js | Added documentation for expected error emission issue |
| tests/rspack-test/configCases/sharing/consume-multiple-versions-ignore-warnings/test.filter.js | Added documentation for warnings not being properly ignored |
| tests/rspack-test/configCases/rule-set/simple/test.filter.js | Removed filter - test now passes |
| tests/rspack-test/configCases/rule-set/simple-use-array-fn/test.filter.js | Removed filter - test now passes |
| tests/rspack-test/configCases/rule-set/chaining/test.filter.js | Removed filter - test now passes |
| tests/rspack-test/configCases/resolve/issue-11335-context-module/test.filter.js | Added documentation for magic comments issue |
| tests/rspack-test/configCases/resolve/context-resolve-with-ignore/test.filter.js | Added documentation for magic comments issue |
| tests/rspack-test/configCases/plugins/lib-manifest-plugin/test.filter.js | Added documentation explaining LibManifestPlugin not exposed |
| tests/rspack-test/configCases/plugins/environment-plugin/test.filter.js | Removed filter - test now passes |
| tests/rspack-test/configCases/parsing/optional/test.filter.js | Added documentation linking to potential fix PR |
| tests/rspack-test/configCases/module/check-defaults/test.filter.js | Removed filter - test now passes |
| tests/rspack-test/configCases/loader/type-module/test.filter.js | Removed filter - test now passes |
| tests/rspack-test/configCases/externals/import-attributes/test.filter.js | Removed filter - test now passes |
| tests/rspack-test/configCases/externals/import-assertion/test.filter.js | Removed filter - test now passes |
| tests/rspack-test/configCases/css-extract/rebuild-module/test.filter.js | Added documentation for worker crash issue |
| tests/rspack-test/configCases/context-modules/exclusion/test.filter.js | Added documentation explaining ContextExclusionPlugin not implemented |
| tests/rspack-test/configCases/clean/dry/test.filter.js | Removed filter - test now passes |
| tests/rspack-test/configCases/chunk-index/recalc-index/test.filter.js | Added documentation for CssModule readableIdentifier issue |
| tests/rspack-test/configCases/builtin-lightningcss-loader/report-warning/test.filter.js | Added documentation for compilation errors |
| tests/rspack-test/configCases/asset-modules/query-and-custom-condition/test.filter.js | Added documentation with issue link |
| tests/rspack-test/configCases/asset-modules/ignore/test.filter.js | Added documentation with issue link |
| tests/rspack-test/configCases/asset-modules/errored/test.filter.js | Added documentation for empty CSS asset issue |
| tests/rspack-test/configCases/asset-modules/custom-condition/test.filter.js | Added documentation with issue link |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/rspack-test/configCases/plugins/lib-manifest-plugin/test.filter.js
Show resolved
Hide resolved
tests/rspack-test/configCases/asset-modules/query-and-custom-condition/test.filter.js
Show resolved
Hide resolved
tests/rspack-test/configCases/split-chunks/entry-point-error/test.filter.js
Show resolved
Hide resolved
tests/rspack-test/configCases/resolve/issue-11335-context-module/test.filter.js
Show resolved
Hide resolved
tests/rspack-test/configCases/asset-modules/query-and-custom-condition/test.filter.js
Show resolved
Hide resolved
Contributor
Rsdoctor Bundle Diff AnalysisFound 5 project(s) in monorepo. 📁 react-10kPath:
📦 Download Diff Report: react-10k Bundle Diff 📁 react-1kPath:
📦 Download Diff Report: react-1k Bundle Diff 📁 react-5kPath:
📦 Download Diff Report: react-5k Bundle Diff 📁 romePath:
📦 Download Diff Report: rome Bundle Diff 📁 ui-componentsPath:
📦 Download Diff Report: ui-components Bundle Diff Generated by Rsdoctor GitHub Action |
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 47.72MB |
CodSpeed Performance ReportMerging #12412 will not alter performanceComparing Summary
|
9aoy
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR systematically reviews and processes configCases test filters without support-related checks:
Enabled Tests (10 test.filter.js removed)
Successfully removed filters for tests that now pass:
clean/dry: Clean plugin dry run testexternals/import-assertion&import-attributes: Import assertions/attributes supportloader/type-module: ES module loader type handlingmodule/check-defaults: Module default config validationplugins/environment-plugin: Environment plugin functionalitysimple,chaining,simple-use-array-fnsplit-chunks/runtime-chunk: Runtime chunk splittingDocumented Failures (16 test.filter.js updated)
Added error documentation for tests that still fail:
Note
Tests with WASM environment checks (
!process.env.WASM) were preserved as they require specific runtime conditions.Checklist