Skip to content

chore(ci): skip diff action for doc-only changes #12437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chenjiahan merged 2 commits into from
Dec 13, 2025
Merged

chore(ci): skip diff action for doc-only changes #12437

chenjiahan merged 2 commits into from
Dec 13, 2025

Conversation

@yifancong
Copy link
Contributor

@yifancong yifancong commented Dec 13, 2025

Summary

chore(ci): optimize the diff action
When the change is in website or is md files, do not execute this diff pipeline.

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Dec 13, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit c74c8d1
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/693d623d6b8e20000889419e

@yifancong yifancong requested a review from chenjiahan December 13, 2025 12:55
@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2025

Rsdoctor Bundle Diff Analysis

Found 5 project(s) in monorepo.

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

📌 Baseline Commit: 19c6cd719b | PR: #12432

Metric Current Baseline Change
📊 Total Size 5.7 MB 5.7 MB 0 B (0.0%)
📄 JavaScript 5.7 MB 5.7 MB 0 B (0.0%)
🎨 CSS 21.0 B 21.0 B 0 B (0.0%)
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: react-10k Bundle Diff

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

📌 Baseline Commit: 19c6cd719b | PR: #12432

Metric Current Baseline Change
📊 Total Size 823.6 KB 823.6 KB 0 B (0.0%)
📄 JavaScript 823.6 KB 823.6 KB 0 B (0.0%)
🎨 CSS 0 B 0 B N/A
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: react-1k Bundle Diff

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

📌 Baseline Commit: 19c6cd719b | PR: #12432

Metric Current Baseline Change
📊 Total Size 2.7 MB 2.7 MB 0 B (0.0%)
📄 JavaScript 2.7 MB 2.7 MB 0 B (0.0%)
🎨 CSS 21.0 B 21.0 B 0 B (0.0%)
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: react-5k Bundle Diff

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

📌 Baseline Commit: 19c6cd719b | PR: #12432

Metric Current Baseline Change
📊 Total Size 2.1 MB 2.1 MB 0 B (0.0%)
📄 JavaScript 2.0 MB 2.0 MB 0 B (0.0%)
🎨 CSS 83.0 KB 83.0 KB 0 B (0.0%)
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: ui-components Bundle Diff

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

📌 Baseline Commit: 19c6cd719b | PR: #12432

Metric Current Baseline Change
📊 Total Size 984.3 KB 984.3 KB 0 B (0.0%)
📄 JavaScript 984.3 KB 984.3 KB 0 B (0.0%)
🎨 CSS 0 B 0 B N/A
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: rome Bundle Diff

Generated by Rsdoctor GitHub Action

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 13, 2025

CodSpeed Performance Report

Merging #12437 will not alter performance

Comparing chore/change-diff-action (c74c8d1) with main (6f3f4de)1

Summary

✅ 17 untouched

Footnotes

  1. No successful run was found on main (19c6cd7) during the generation of this report, so 6f3f4de was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@chenjiahan chenjiahan changed the title chore(ci): optimize the diff action chore(ci): skip diff action for website and markdown-only changes Dec 13, 2025
@chenjiahan chenjiahan changed the title chore(ci): skip diff action for website and markdown-only changes chore(ci): skip diff action for doc-only changes Dec 13, 2025
@chenjiahan chenjiahan marked this pull request as ready for review December 13, 2025 13:55
Copilot AI review requested due to automatic review settings December 13, 2025 13:55
@chenjiahan chenjiahan enabled auto-merge (squash) December 13, 2025 13:55
@chenjiahan
Copy link
Member

chenjiahan commented Dec 13, 2025

👍

Copilot AI reviewed Dec 13, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes the CI Diff workflow by skipping execution when changes only affect documentation files (Markdown files and the website directory). It also renames the job from "demo-test" to "diff-projects" to better reflect its purpose of benchmarking and diffing projects.

Key changes:

  • Add paths-ignore configuration to skip workflow for Markdown and website-only changes
  • Rename job from "demo-test" to "diff-projects" with updated display name "Diff Benchmark Projects"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2025

📦 Binary Size-limit

Comparing c74c8d1 to chore: bump swc_experimental to fix parsing utf8 in template (#12431) by CPunisher

🙈 Size remains the same at 48.20MB

@chenjiahan chenjiahan merged commit 56154ad into main Dec 13, 2025
62 checks passed
@chenjiahan chenjiahan deleted the chore/change-diff-action branch December 13, 2025 14:57
This was referenced Dec 14, 2025
Merged
Merged
Merged
Merged
Merged
@CPunisher CPunisher mentioned this pull request Dec 17, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@chenjiahan chenjiahan chenjiahan approved these changes

@stormslowly stormslowly Awaiting requested review from stormslowly stormslowly is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yifancong @chenjiahan