Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

This PR moves module.rules into its own documentation page to improve structure and readability.

The original module page had become too long, making it harder to navigate. By splitting out module.rules, the documentation structure is clearer, and the new page provides a more focused introduction, especially helpful for new users.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings December 15, 2025 06:56
@netlify
Copy link

netlify bot commented Dec 15, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 59b7970
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/693fb740aaaa980008811ac8
😎 Deploy Preview https://deploy-preview-12452--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@chenjiahan chenjiahan changed the title docs: refactor module.rules documentation into a dedicated page docs: refactor module.rules options into a dedicated page Dec 15, 2025
@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: document release: document related release(mr only) labels Dec 15, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR successfully refactors the module.rules documentation from the main module configuration page into a dedicated page (module-rules.mdx). This improves documentation structure and makes it easier to navigate module rules configuration.

Key Changes

  • Created new dedicated pages website/docs/{zh,en}/config/module-rules.mdx with comprehensive module.rules documentation
  • Updated module.mdx files to remove the module.rules content and add a reference link to the new page
  • Updated _meta.json files to include the new module-rules entry in navigation
  • Systematically updated all cross-references throughout the documentation from Rule.* to rules[].* format (e.g., Rule.typerules[].type)
  • Corrected version naming from "Vue3/Vue2" to "Vue 3/Vue 2" for consistency

Reviewed changes

Copilot reviewed 42 out of 44 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
website/docs/zh/config/module-rules.mdx New Chinese documentation page for module.rules with comprehensive coverage of all rule options
website/docs/en/config/module-rules.mdx New English documentation page for module.rules with comprehensive coverage of all rule options
website/docs/zh/config/module.mdx Removed module.rules section and added reference link to new page
website/docs/en/config/module.mdx Removed module.rules section and added reference link to new page
website/docs/{zh,en}/config/_meta.json Added module-rules entry to navigation structure
Various guide and blog files Updated all references from Rule.* to rules[].* notation and fixed Vue version naming

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chenjiahan chenjiahan enabled auto-merge (squash) December 15, 2025 07:25
@chenjiahan chenjiahan merged commit 6fde634 into main Dec 15, 2025
26 checks passed
@chenjiahan chenjiahan deleted the module_rules_doc_1215 branch December 15, 2025 07:46
LingyuCoder pushed a commit that referenced this pull request Dec 15, 2025
* docs: refactor `module.rules` documentation into a dedicated page

* docs: fix
LingyuCoder added a commit that referenced this pull request Dec 16, 2025
docs: refactor `module.rules` options into a dedicated page (#12452)

* docs: refactor `module.rules` documentation into a dedicated page

* docs: fix

Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
@CPunisher CPunisher mentioned this pull request Dec 17, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: document release: document related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants