Skip to content

refactor: remove all option in ModuleGraphData #12568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chenjiahan merged 3 commits into from
Dec 27, 2025
Merged

refactor: remove all option in ModuleGraphData #12568

chenjiahan merged 3 commits into from
Dec 27, 2025

Conversation

@hardfist
Copy link
Contributor

@hardfist hardfist commented Dec 27, 2025 •
edited
Loading

Summary

followup of #12567

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Dec 27, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit ed93b58
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/694f84e23d0ba60008e2a87c

@github-actions github-actions bot added release: refactor team The issue/pr is created by the member of Rspack. labels Dec 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 27, 2025 •
edited
Loading

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 0 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB 0
react-1k 823.4 KB 0
react-5k 2.7 MB 0
ui-components 2.1 MB 0
rome 984.3 KB 0

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Contributor

github-actions bot commented Dec 27, 2025 •
edited
Loading

📦 Binary Size-limit

Comparing ed93b58 to feat: mangle exports of css modules (#12563) by harpsealjs

🎉 Size decreased by 2.25KB from 48.00MB to 48.00MB (⬇️0.00%)

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 27, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #12568 will not alter performance

Comparing yj/remove-option-mg (ed93b58) with main (2ca0498)

Summary

✅ 16 untouched
⏩ 1 skipped1

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

@hardfist hardfist marked this pull request as ready for review December 27, 2025 06:08
Copilot AI review requested due to automatic review settings December 27, 2025 06:08
Copilot AI reviewed Dec 27, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the ModuleGraphData internal data structures by removing Option wrappers from four key fields (modules, dependencies, blocks, module_graph_modules, and connections). This simplification eliminates the need for Option-based removal patterns and makes the code more straightforward by using direct values instead of optional wrappers.

Key changes:

  • Changed field types from Option<T> to T for modules, dependencies, blocks, and connections
  • Replaced removal operations using insert(key, None) with proper remove(key) calls
  • Simplified accessor methods by removing unnecessary as_ref() and as_mut() conversions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hardfist hardfist changed the title refactor: remove all operation in modulegraphdata refactor: remove all option in ModuleGraphData Dec 27, 2025
@chenjiahan chenjiahan enabled auto-merge (squash) December 27, 2025 07:18
@chenjiahan chenjiahan merged commit 3e8ba27 into main Dec 27, 2025
53 checks passed
@chenjiahan chenjiahan deleted the yj/remove-option-mg branch December 27, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees

No one assigned

Labels

release: refactor team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hardfist @chenjiahan