Skip to content

ci: only download bindings artifacts during release #12604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chenjiahan merged 2 commits into from
Jan 1, 2026
Merged

ci: only download bindings artifacts during release #12604

chenjiahan merged 2 commits into from
Jan 1, 2026
+15 −6

Conversation

@stormslowly
Copy link
Contributor

@stormslowly stormslowly commented Dec 31, 2025 •
edited
Loading

Summary

  1. Download bindings-* pattern artifacts, so new added artifacts will not break npm binding release.
  2. Disable all fast-fail; test actions are flaky, fail fast results lots reruns.

Verified: https://github.com/web-infra-dev/rspack/actions/runs/20613663676/job/59204899567

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Dec 31, 2025
@netlify
Copy link

netlify bot commented Dec 31, 2025 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 9a58f22
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/6954ccd60b2d510008971767
😎 Deploy Preview https://deploy-preview-12604--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@stormslowly stormslowly changed the title fix(CI): download bindings-* artifacts only when release fix(CI): download bindings-xxx artifacts only when release Dec 31, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 31, 2025 •
edited
Loading

Rsdoctor Bundle Diff Analysis

⚠️ Note: The latest commit (8d89f8fc70) does not have baseline artifacts. Using commit 08451267d3 for baseline comparison instead. If this seems incorrect, please wait a few minutes and try rerunning the workflow.

Found 5 projects in monorepo, 5 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB +14.0 B (0.0%)
react-1k 823.4 KB +14.0 B (0.0%)
react-5k 2.7 MB +14.0 B (0.0%)
rome 984.4 KB +14.0 B (0.0%)
ui-components 2.1 MB +14.0 B (0.0%)
📋 Detailed Reports (Click to expand)

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

📌 Baseline Commit: 08451267d3 | PR: #12595

Metric Current Baseline Change
📊 Total Size 5.7 MB 5.7 MB +14.0 B (0.0%)
📄 JavaScript 5.7 MB 5.7 MB +14.0 B (0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-10k Bundle Diff

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

📌 Baseline Commit: 08451267d3 | PR: #12595

Metric Current Baseline Change
📊 Total Size 823.4 KB 823.4 KB +14.0 B (0.0%)
📄 JavaScript 823.4 KB 823.4 KB +14.0 B (0.0%)
🎨 CSS 0 B 0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-1k Bundle Diff

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

📌 Baseline Commit: 08451267d3 | PR: #12595

Metric Current Baseline Change
📊 Total Size 2.7 MB 2.7 MB +14.0 B (0.0%)
📄 JavaScript 2.7 MB 2.7 MB +14.0 B (0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-5k Bundle Diff

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

📌 Baseline Commit: 08451267d3 | PR: #12595

Metric Current Baseline Change
📊 Total Size 984.4 KB 984.3 KB +14.0 B (0.0%)
📄 JavaScript 984.4 KB 984.3 KB +14.0 B (0.0%)
🎨 CSS 0 B 0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: rome Bundle Diff

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

📌 Baseline Commit: 08451267d3 | PR: #12595

Metric Current Baseline Change
📊 Total Size 2.1 MB 2.1 MB +14.0 B (0.0%)
📄 JavaScript 2.0 MB 2.0 MB +14.0 B (0.0%)
🎨 CSS 83.0 KB 83.0 KB 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: ui-components Bundle Diff

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Contributor

github-actions bot commented Dec 31, 2025 •
edited
Loading

📦 Binary Size-limit

Comparing 9a58f22 to chore: release v1.7.0 (#12595) by CPunisher

🙈 Size remains the same at 47.85MB

@stormslowly stormslowly changed the title fix(CI): download bindings-xxx artifacts only when release fix(ci): download bindings-xxx artifacts only when release Dec 31, 2025
@chenjiahan chenjiahan changed the title fix(ci): download bindings-xxx artifacts only when release ci: only download bindings artifacts during release Dec 31, 2025
@github-actions github-actions bot removed the release: bug fix release: bug related release(mr only) label Dec 31, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 31, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #12604 will not alter performance

Comparing chore/fix_artficats_downloads (9a58f22) with main (0845126)1

Summary

✅ 16 untouched
⏩ 1 skipped2

Footnotes

  1. No successful run was found on main (5bddce0) during the generation of this report, so 0845126 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

@stormslowly stormslowly marked this pull request as ready for review December 31, 2025 16:10
Copilot AI reviewed Dec 31, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the reliability of npm binding releases by filtering artifact downloads and making CI workflows more resilient to flaky tests.

Key Changes:

  • Added pattern: bindings-* filter to artifact downloads in release workflows to prevent unrelated artifacts from breaking npm releases
  • Disabled fail-fast strategy across multiple build workflows to allow all jobs to complete despite flaky test failures
  • Added temporary debug logging (ls -R artifacts) to verify artifact download behavior

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
.github/workflows/reusable-release-npm.yml Added artifact pattern filter and debug logging for npm releases
.github/workflows/reusable-build-all.yml Disabled fail-fast to prevent premature job cancellation
.github/workflows/release-debug.yml Added artifact pattern filter and debug logging for debug releases
.github/workflows/release-canary.yml Added artifact pattern filter, debug logging, and disabled fail-fast for canary releases
.github/workflows/preview-commit.yml Disabled fail-fast for commit preview builds

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

chenjiahan
chenjiahan reviewed Jan 1, 2026
View reviewed changes
@chenjiahan chenjiahan merged commit 1175ddf into main Jan 1, 2026
137 of 143 checks passed
@chenjiahan chenjiahan deleted the chore/fix_artficats_downloads branch January 1, 2026 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@chenjiahan chenjiahan chenjiahan approved these changes

@CPunisher CPunisher Awaiting requested review from CPunisher

Assignees

No one assigned

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stormslowly @chenjiahan