fix: should export rspack function from `compiler.rspack` #12636

LingyuCoder · 2026-01-06T03:00:15Z

Summary

The RuntimeGlobals should be different between compiler.rspack and the exports of @rspack/core. So we need to create a new exports object for each compiler and should not just assign the new RuntimeGlobals to exports to prevent overriding it.

Checklist

Tests updated (or not required).
Documentation updated (or not required).

gemini-code-assist · 2026-01-06T03:00:29Z

Summary of Changes

Hello @LingyuCoder, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This PR addresses a critical issue concerning the isolation of RuntimeGlobals within the Rspack compiler. Previously, RuntimeGlobals could be inadvertently shared or overridden, causing unpredictable behavior. The fix introduces a mechanism to create a unique RuntimeGlobals object for each compiler instance, ensuring proper encapsulation and preventing conflicts, thereby stabilizing the compilation process.

Highlights

Fixing RuntimeGlobals Isolation: This pull request resolves an issue where RuntimeGlobals were not properly isolated between compiler.rspack and the exports of @rspack/core, leading to potential overrides.
Dedicated Compiler Exports: A new exports object is now created for each compiler instance, ensuring that compiler.rspack and compiler.webpack receive their own distinct RuntimeGlobals without affecting the global @rspack/core exports.
New Test Case: A new test file, exports.js, has been added to verify that compiler.rspack is a function, contains expected properties, and its RuntimeGlobals are indeed separate from those directly imported from @rspack/core.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

netlify · 2026-01-06T03:00:49Z

✅ Deploy Preview for rspack canceled.

Name	Link
🔨 Latest commit	`d408911`
🔍 Latest deploy log	https://app.netlify.com/projects/rspack/deploys/695c83614a4f0d0008e9d3cf

gemini-code-assist

Code Review

This pull request aims to fix an issue with compiler.rspack in multi-compiler setups by ensuring each compiler gets its own RuntimeGlobals. The approach taken correctly identifies that compiler.rspack needs to be a function, but the implementation inadvertently modifies a shared singleton, which would cause issues in the very multi-compiler scenario it's trying to fix. I've provided a critical comment with a suggested fix to create a new function for each compiler instance, ensuring proper isolation. A new test case has also been added which is great for verifying the intended behavior.

packages/rspack/src/Compiler.ts

Copilot

Pull request overview

This PR fixes an issue where RuntimeGlobals should be unique for each compiler instance rather than shared across all exports from @rspack/core. The fix ensures that compiler.rspack and compiler.webpack have compiler-specific RuntimeGlobals instances.

Key changes:

Added a test to verify compiler.rspack exports the rspack function with unique RuntimeGlobals
Modified Compiler.ts to create compiler-specific rspack exports with per-compiler RuntimeGlobals
Changed imports to separate the rspack function from the exports module

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
tests/rspack-test/compilerCases/exports.js	Adds test verifying compiler.rspack is a function with unique RuntimeGlobals instance
packages/rspack/src/Compiler.ts	Creates compiler-specific rspack exports object with per-compiler RuntimeGlobals and self-references

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/rspack-test/compilerCases/exports.js

packages/rspack/src/Compiler.ts

github-actions · 2026-01-06T03:09:47Z

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 0 projects with changes.

📊 Quick Summary

Project	Total Size	Change
react-10k	5.7 MB	0
react-1k	825.4 KB	0
react-5k	2.7 MB	0
rome	984.3 KB	0
ui-components	2.1 MB	0

Generated by Rsdoctor GitHub Action

github-actions · 2026-01-06T03:10:17Z

📦 Binary Size-limit

Comparing d408911 to refactor: replace UsageCallback closure with InnerGraphUsageOperation enum (#12619) by Fy

🙈 Size remains the same at 47.87MB

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

packages/rspack/src/Compiler.ts

codspeed-hq · 2026-01-06T03:33:58Z

CodSpeed Performance Report

Merging #12636 will not alter performance

_{Comparing fix/compiler-exports (d408911) with main (3de0ea5)}

Summary

✅ 16 untouched
⏩ 1 skipped¹

1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

fix: exports function from compiler.rspack

15e1683

LingyuCoder requested a review from hardfist as a code owner January 6, 2026 03:00

LingyuCoder requested review from chenjiahan and Copilot January 6, 2026 03:00

github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Jan 6, 2026

Copilot started reviewing on behalf of LingyuCoder January 6, 2026 03:00 View session

gemini-code-assist bot reviewed Jan 6, 2026

View reviewed changes

packages/rspack/src/Compiler.ts Outdated Show resolved Hide resolved

Copilot AI reviewed Jan 6, 2026

View reviewed changes

tests/rspack-test/compilerCases/exports.js Show resolved Hide resolved

tests/rspack-test/compilerCases/exports.js Outdated Show resolved Hide resolved

packages/rspack/src/Compiler.ts Outdated Show resolved Hide resolved

LingyuCoder and others added 2 commits January 6, 2026 11:10

fix: exports function from compiler.rspack

d3ae863

Update tests/rspack-test/compilerCases/exports.js

6bb6ad7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

chenjiahan reviewed Jan 6, 2026

View reviewed changes

packages/rspack/src/Compiler.ts Outdated Show resolved Hide resolved

fix: exports function from compiler.rspack

d408911

chenjiahan approved these changes Jan 6, 2026

View reviewed changes

chenjiahan enabled auto-merge (squash) January 6, 2026 03:45

chenjiahan merged commit 9f09ed1 into main Jan 6, 2026
77 of 79 checks passed

chenjiahan deleted the fix/compiler-exports branch January 6, 2026 04:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: should export rspack function from `compiler.rspack` #12636

fix: should export rspack function from `compiler.rspack` #12636

Uh oh!

LingyuCoder commented Jan 6, 2026

Uh oh!

gemini-code-assist bot commented Jan 6, 2026

Uh oh!

netlify bot commented Jan 6, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 6, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 6, 2026 •

edited

Loading

Uh oh!

Uh oh!

codspeed-hq bot commented Jan 6, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

fix: should export rspack function from compiler.rspack #12636

fix: should export rspack function from compiler.rspack #12636

Uh oh!

Conversation

LingyuCoder commented Jan 6, 2026

Summary

Related links

Checklist

Uh oh!

gemini-code-assist bot commented Jan 6, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

netlify bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rspack canceled.

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rsdoctor Bundle Diff Analysis

Uh oh!

github-actions bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Binary Size-limit

Uh oh!

Uh oh!

codspeed-hq bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #12636 will not alter performance

Summary

Footnotes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: should export rspack function from `compiler.rspack` #12636

fix: should export rspack function from `compiler.rspack` #12636

netlify bot commented Jan 6, 2026 •

edited

Loading

github-actions bot commented Jan 6, 2026 •

edited

Loading

github-actions bot commented Jan 6, 2026 •

edited

Loading

codspeed-hq bot commented Jan 6, 2026 •

edited

Loading