fix(lint): enable @typescript-eslint/await-thenable rule #12644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enable @typescript-eslint/await-thenable rule (off -> error) - Remove unnecessary await on syncTraceEvent() which returns void
✅ Deploy Preview for rspack canceled.
|
chenjiahan
reviewed
Jan 7, 2026
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
LingyuCoder
pushed a commit
that referenced
this pull request
Jan 8, 2026
* fix(lint): enable await-thenable rule and fix violation - Enable @typescript-eslint/await-thenable rule (off -> error) - Remove unnecessary await on syncTraceEvent() which returns void * Update rslint.json --------- Co-authored-by: neverland <jait.chen@foxmail.com>
hardfist
added a commit
that referenced
this pull request
Jan 23, 2026
* react_server_components transform * fix: ReactServerComponents * ReactServerComponentPlugin * fix: rspack_loader_swc Wtf8Atom * feat: ReactServerComponentPlugin * feat: ServerEntryModules * exports_info * temp * feat: import with layer * fix: before pass * export ReactServerComponentsPlugin * ServerEntries * feat: client_entry_loader * feat: client compiler * feat: traverse_modules * feat: ClientReferenceManifestPlugin * feat: react_server_components layer * fix ReactClientPlugin * fix: ClientReferenceManifestPlugin * refactor: rename to ReactServerPlugin * remove eager * feat: collect entry css files * feat: use server-entry * server actions transform * feat: action_entry_loader * collect server_actions * temp * manifest-loader * RscManifestRuntimeModule * fix: build_server_consumer_module_map * fix: entry_css_files * feat: record_entry_js_files * refactor: entry_css_files * fix: entry js files and entry css files should concat prefix * remove unused code * chore: rename loader and plugin * fix: Coordinator * fix: entry js files prevent hot-module files from being included * clear PLUGIN_STATE_BY_COMPILER_ID * feat: add_include client action * feat: prev_server_component_hashs * fix: client compiler not rebuild right * export RSC_LAYERS_NAMES * fix: remove import with layer * refactor: rsc_pass * refactor: rsc_meta * refactor: to_module_ref * fix: cargo clippy * fix: lint and spelling * api changed * refactor: use get_module_resource * fix: ts type * fix: compiler watching * feat: check should_inject_ssr_modules * fix: only invalidate client after proxying client watching * fix: client module chunks should exclude hot module replacement js * chore: rename coordinator mod * fix: collect_component_info_from_entry_denendency * fix: panic in create_client_entries * fix: browser action * rm ACTION_BROWSER layer * fix: use atomic ref * refactor client plugin * fix: should handle compile failed * chore: rm unused print * fix: use server-entry mix use client * feat: ensureServerActions * fix: RSC_HOT_RELOADER * refactor: create_client_entries * fix: encryptActionBoundArgs and decryptActionBoundArgs * fix: should collect entry css files in after_process_assets hook * fix: with concat module * chore(deps): update patch npm dependencies (#12647) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update patch crates (#12646) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: run ci/eco-ci/eco-benchmark on v2 branch (#12650) * fix: report error when access module_graph in loader (#12639) * fix: report error when access module_graph in loader * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat(rstest): add preserveNewUrl option to keep new URL untouched (#12632) * feat(rstest): add preserveNewUrl option to keep new URL untouched * fix: format Rust code with rustfmt * fix(lint): enable @typescript-eslint/await-thenable rule (#12644) * fix(lint): enable await-thenable rule and fix violation - Enable @typescript-eslint/await-thenable rule (off -> error) - Remove unnecessary await on syncTraceEvent() which returns void * Update rslint.json --------- Co-authored-by: neverland <jait.chen@foxmail.com> * fix: cargo clippy * refactor: rm RSC_HOT_RELOADER runtime module * fix: lint check * refactor: rename RscPluginLayers * warp rsc in namespace * fix: rsc client plugin * fix: cargo fmt * add next.js Copyright * fix: user can change fileDependencies in done hook * chore: add comments * fix: cargo fmt * rm ustr dependencies --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: harpsealjs <lingyucoder@gmail.com> Co-authored-by: hardfist <yangjianzju@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Max <fi3ework@gmail.com> Co-authored-by: Tu Shaokun <53142663+tt-a1i@users.noreply.github.com> Co-authored-by: neverland <jait.chen@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enables
@typescript-eslint/await-thenablerule and fixes the single violation found.Changes:
rslint.json: Changed@typescript-eslint/await-thenablefromofftoerrorpackages/rspack/src/exports.ts: Removed unnecessaryawaitonsyncTraceEvent()which returnsvoid, not a PromiseRelated to #11761
AI Assistance Disclosure
I used Codex to review the changes, sanity-check the implementation against existing patterns, and help spot potential edge cases.