fix(context-replacement): only apply changes when regex matches #12657
+35
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
Merging this PR will not alter performance
Comparing 
Footnotes
|
SyMind
approved these changes
Jan 13, 2026
Member
|
Thank you! ❤️ |
The plugin was applying transformations (recursive, regExp, critical) to all require.context() calls regardless of whether the configured regex pattern matched the request. This fix ensures all transformations only apply when the regex successfully matches. Closes web-infra-dev#12656
auto-merge was automatically disabled
January 13, 2026 04:26
Head branch was pushed to by a user without write access
0300b88 to
2c9cfd8
Compare
Contributor
Author
|
@chenjiahan @SyMind rebased with main branch since some unexpected test failures |
SyMind
approved these changes
Jan 13, 2026
2 tasks
LingyuCoder
pushed a commit
that referenced
this pull request
Jan 14, 2026
fix(ContextReplacementPlugin): only apply changes when regex matches The plugin was applying transformations (recursive, regExp, critical) to all require.context() calls regardless of whether the configured regex pattern matched the request. This fix ensures all transformations only apply when the regex successfully matches. Closes #12656
LingyuCoder
pushed a commit
that referenced
this pull request
Jan 14, 2026
fix(ContextReplacementPlugin): only apply changes when regex matches The plugin was applying transformations (recursive, regExp, critical) to all require.context() calls regardless of whether the configured regex pattern matched the request. This fix ensures all transformations only apply when the regex successfully matches. Closes #12656
hardfist
pushed a commit
that referenced
this pull request
Jan 14, 2026
fix(ContextReplacementPlugin): only apply changes when regex matches The plugin was applying transformations (recursive, regExp, critical) to all require.context() calls regardless of whether the configured regex pattern matched the request. This fix ensures all transformations only apply when the regex successfully matches. Closes #12656
LingyuCoder
pushed a commit
that referenced
this pull request
Jan 15, 2026
fix(ContextReplacementPlugin): only apply changes when regex matches The plugin was applying transformations (recursive, regExp, critical) to all require.context() calls regardless of whether the configured regex pattern matched the request. This fix ensures all transformations only apply when the regex successfully matches. Closes #12656
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ContextReplacementPluginapplied transformations to allrequire.context()calls regardless of regex matchnew_content_resourceconditional, causingrecursive,regExp, andcriticalmodifications to apply to non-matching contextsTest plan
context-replacement/non-matching-regexthat verifies non-matching contexts are not affectedCloses #12656