fix: inlined export invalid syntax comment #12681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where inlined export comments were placed outside parentheses, creating invalid JavaScript syntax in certain contexts (especially division operations). The fix moves comments inside the parentheses.
Key changes:
- Modified
EvaluatedInlinableValue::render()andInlinedUsedName::render()to accept acommentparameter and place it inside parentheses:(/* comment */value)instead of/* comment */ (value) - Updated all call sites across the codebase to pass the appropriate comment string
- Added a new test case to verify the fix works correctly for division expressions
Reviewed changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
crates/rspack_core/src/exports/utils.rs |
Core fix: Modified render methods to accept comment parameter and place it inside parentheses |
crates/rspack_core/src/concatenated_module.rs |
Updated all inlined value render calls to use new API with comment parameter |
crates/rspack_core/src/runtime_template.rs |
Updated inlined value render call to use new API |
crates/rspack_core/src/exports/export_info_getter.rs |
Updated render call with empty comment for rename info |
crates/rspack_plugin_esm_library/src/link.rs |
Updated multiple inlined value render calls with appropriate comments |
crates/rspack_plugin_javascript/src/dependency/esm/esm_export_imported_specifier_dependency.rs |
Updated to generate proper comment for inlined exports |
crates/rspack_plugin_javascript/src/dependency/commonjs/common_js_*.rs |
Updated CommonJS dependency handlers to use new render API |
crates/rspack_plugin_library/src/*.rs |
Updated library plugin render calls with empty comments |
tests/rspack-test/configCases/inline-const/generated-syntax/* |
New test case verifying fix for division expression syntax |
tests/rspack-test/configCases/rsdoctor/assets/rspack.config.js |
Updated expected file sizes (1 byte reduction per file) |
| All other test snapshot files | Updated snapshots to reflect new comment placement inside parentheses |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Contributor
📦 Binary Size-limit
🎉 Size decreased by 768bytes from 47.87MB to 47.87MB (⬇️0.00%) |
Merging this PR will not alter performanceSummary
Comparing 
Footnotes
|
JSerFeng
approved these changes
Jan 9, 2026
LingyuCoder
pushed a commit
that referenced
this pull request
Jan 9, 2026
LingyuCoder
pushed a commit
that referenced
this pull request
Jan 14, 2026
LingyuCoder
pushed a commit
that referenced
this pull request
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #12631
Related links
Checklist