refactor: move pass into separate folder and driven by run_passes #12735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
Contributor
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Contributor
📦 Binary Size-limit
❌ Size increased by 45.25KB from 47.97MB to 48.01MB (⬆️0.09%) |
Merging this PR will not alter performance
Comparing 
Footnotes
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the Rspack compilation process by moving individual compilation passes from a monolithic mod.rs file into separate, dedicated modules. Inspired by Rust's rustc_passes design, this change improves code organization, maintainability, and separation of concerns.
Changes:
- Extracted 16 compilation passes into separate modules (optimize_dependencies, build_chunk_graph, optimize_modules, optimize_chunks, optimize_tree, optimize_chunk_modules, module_ids, chunk_ids, assign_runtime_ids, optimize_code_generation, create_module_hashes, code_generation, runtime_requirements, create_hash, create_module_assets, create_chunk_assets, process_assets, after_seal, finish_module)
- Created
run_passes.rsto orchestrate all compilation passes in a single location - Added comprehensive documentation in
rspack_passes.mddescribing the modular architecture and pass execution order
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/rspack_core/src/compilation/mod.rs | Removed large blocks of compilation pass code; added module declarations for new pass modules; removed obsolete imports |
| crates/rspack_core/src/compilation/run_passes.rs | New orchestration module that drives all compilation passes in sequence |
| crates/rspack_core/src/compilation/rspack_passes.md | Documentation describing the new modular architecture and pass order |
| crates/rspack_core/src/compilation/runtime_requirements/mod.rs | Extracted runtime requirements pass implementation |
| crates/rspack_core/src/compilation/process_assets/mod.rs | Extracted process assets pass implementation |
| crates/rspack_core/src/compilation/optimize_tree/mod.rs | Extracted optimize tree pass implementation |
| crates/rspack_core/src/compilation/optimize_modules/mod.rs | Extracted optimize modules pass implementation |
| crates/rspack_core/src/compilation/optimize_dependencies/mod.rs | Extracted optimize dependencies pass implementation |
| crates/rspack_core/src/compilation/optimize_code_generation/mod.rs | Extracted optimize code generation pass implementation |
| crates/rspack_core/src/compilation/optimize_chunks/mod.rs | Extracted optimize chunks pass implementation |
| crates/rspack_core/src/compilation/optimize_chunk_modules/mod.rs | Extracted optimize chunk modules pass implementation |
| crates/rspack_core/src/compilation/module_ids/mod.rs | Extracted module IDs pass implementation |
| crates/rspack_core/src/compilation/finish_module/mod.rs | Extracted finish module pass implementation |
| crates/rspack_core/src/compilation/create_module_hashes/mod.rs | Extracted module hashes creation pass implementation |
| crates/rspack_core/src/compilation/create_module_assets/mod.rs | Extracted module assets creation pass implementation |
| crates/rspack_core/src/compilation/create_hash/mod.rs | Extracted hash creation pass implementation; includes ChunkHashResult struct definition |
| crates/rspack_core/src/compilation/create_chunk_assets/mod.rs | Extracted chunk assets creation pass implementation |
| crates/rspack_core/src/compilation/code_generation/mod.rs | Extracted code generation pass implementation |
| crates/rspack_core/src/compilation/chunk_ids/mod.rs | Extracted chunk IDs pass implementation |
| crates/rspack_core/src/compilation/build_chunk_graph/pass.rs | New pass wrapper for build chunk graph |
| crates/rspack_core/src/compilation/build_chunk_graph/mod.rs | Added pass module declaration |
| crates/rspack_core/src/compilation/assign_runtime_ids/mod.rs | Extracted runtime IDs assignment pass implementation |
| crates/rspack_core/src/compilation/after_seal/mod.rs | Extracted after seal pass implementation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stormslowly
approved these changes
Jan 15, 2026
This was referenced Jan 15, 2026
LingyuCoder
pushed a commit
that referenced
this pull request
Jan 16, 2026
…2735) * chore: add rspack_passes.md * refactor: move pass into separate folder and drive by run_passes * chore: use function * refactor: move more into run_passes * chore: fix stats logging * chore: fix stats.logging
chenjiahan
pushed a commit
that referenced
this pull request
Jan 16, 2026
…2735) * chore: add rspack_passes.md * refactor: move pass into separate folder and drive by run_passes * chore: use function * refactor: move more into run_passes * chore: fix stats logging * chore: fix stats.logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Inspired by rustc's rustc_passes design(https://github.com/rust-lang/rust/blob/e314b97ee54091b6bcf33db4770c93d82fded8bc/compiler/rustc_passes/src/lib.rs#L39),
move every pass into seperate folder and remove the complexity of compilation.rs and drive all these passes in run_passes function which
Follow up:
Related links
Checklist