Skip to content

chore(lint): bump @rslint/core to 0.2.0 and enable default-param-last rule #12746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chenjiahan merged 2 commits into from
Jan 15, 2026
Merged

chore(lint): bump @rslint/core to 0.2.0 and enable default-param-last rule #12746

chenjiahan merged 2 commits into from
Jan 15, 2026
+46 −34

Conversation

@fansenze
Copy link
Contributor

@fansenze fansenze commented Jan 15, 2026 •
edited
Loading

Summary

  • bump @rslint/core to 0.2.0 and update rslint.json configuration
  • Enable @typescript-eslint/default-param-last lint rule and fix existing violations in
    packages/rspack/src/MultiStats.ts

Changes

  • Updated @rslint/core dependency to version 0.2.0
  • Added new lint rule configurations in rslint.json
  • Fixed parameter ordering in packages/rspack/src/MultiStats.ts to comply with the
    default-param-last rule

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@fansenze fansenze requested a review from hardfist as a code owner January 15, 2026 08:11
@netlify
Copy link

netlify bot commented Jan 15, 2026 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit f01c6e4
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/6968a138503d9d0008b8523e

@fansenze fansenze changed the title Chore/bump rslint to 0.2.0 chore(lint): bump @rslint/core to 0.2.0 and enable default-param-last rule Jan 15, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 0 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB 0
react-1k 825.4 KB 0
react-5k 2.7 MB 0
rome 984.3 KB 0
ui-components 2.1 MB 0

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026

📦 Binary Size-limit

Comparing f01c6e4 to refactor: move logger into pass and reorg some passes (#12742) by hardfist

🙈 Size remains the same at 48.03MB

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 15, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing chore/bump-rslint-to-0.2.0 (f01c6e4) with main (0eb2ee3)

Summary

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark1

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

@chenjiahan chenjiahan merged commit cd15818 into main Jan 15, 2026
83 of 86 checks passed
@chenjiahan chenjiahan deleted the chore/bump-rslint-to-0.2.0 branch January 15, 2026 08:47
This was referenced Jan 15, 2026
Merged
Merged
Merged
LingyuCoder pushed a commit that referenced this pull request Jan 16, 2026
@fansenze @LingyuCoder
chore(lint): bump @rslint/core to 0.2.0 and enable default-param-last…
88d5be7 
… rule (#12746)

* chore(deps): bump @rslint/core to 0.2.0 and update rslint.json

* fix(lint): enable @typescript-eslint/default-param-last rule
chenjiahan pushed a commit that referenced this pull request Jan 16, 2026
@fansenze @chenjiahan
chore(lint): bump @rslint/core to 0.2.0 and enable default-param-last…
84fd6a7 
… rule (#12746)

* chore(deps): bump @rslint/core to 0.2.0 and update rslint.json

* fix(lint): enable @typescript-eslint/default-param-last rule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

@hardfist hardfist Awaiting requested review from hardfist hardfist is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fansenze @chenjiahan