fix(browser): update worker format and add e2e test #12747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the @rspack/browser package to fix worker format issues and adds basic end-to-end testing. The changes address runtime errors by switching the worker entry format from esm to iife and properly handling lazy compilation middleware for browser environments.
Changes:
- Changed worker entry format from
esmtoiifein rslib.browser.config.mts to resolve rslib runtime import errors - Added middleware stub for lazy compilation that throws an error since it's not supported in browser environments
- Added basic-react e2e test case for
@rspack/browserwith conditional test directory switching based on WASM environment variable
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/rspack/rslib.browser.config.mts | Updated worker format from esm to iife and added middleware replacement plugin |
| packages/rspack/src/browser/middleware.ts | Added stub that throws error for unsupported lazy compilation middleware |
| tests/e2e/playwright.config.ts | Added conditional test directory based on WASM environment variable |
| tests/e2e/tsconfig.json | Added browser-cases to include paths |
| tests/e2e/package.json | Added @rspack/browser as dependency |
| tests/e2e/browser-cases/basic-react/* | New e2e test for @rspack/browser with React app bundling |
| .github/workflows/reusable-build-test.yml | Added separate e2e job for wasm32-wasi-threads target with WASM=1 |
| pnpm-lock.yaml | Updated to include @rspack/browser in e2e tests |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 48.03MB |
Merging this PR will not alter performance
Comparing 
Footnotes
|
Timeless0911
approved these changes
Jan 19, 2026
2 tasks
LingyuCoder
pushed a commit
that referenced
this pull request
Jan 19, 2026
* fix: remove lazyCompilationMiddleware * chore: change worker entry to iife * chore: add e2e test * chore: fix format * fix: add await for e2e * fix: remove unused imports * chore: fix ci yml * chore: fix ci WASM env injection
LingyuCoder
pushed a commit
that referenced
this pull request
Jan 19, 2026
* fix: remove lazyCompilationMiddleware * chore: change worker entry to iife * chore: add e2e test * chore: fix format * fix: add await for e2e * fix: remove unused imports * chore: fix ci yml * chore: fix ci WASM env injection
Merged
2 tasks
chenjiahan
pushed a commit
that referenced
this pull request
Jan 19, 2026
* fix: remove lazyCompilationMiddleware * chore: change worker entry to iife * chore: add e2e test * chore: fix format * fix: add await for e2e * fix: remove unused imports * chore: fix ci yml * chore: fix ci WASM env injection
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
lazyCompilationMiddlewaresupport in @rspack/browseresmtoiifeto fix the imported rslib runtime errors.Checklist