feat: support import and export string specifier #12759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack-v2 canceled.
|
ahabhgk
previously approved these changes
Jan 16, 2026
Contributor
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Contributor
📦 Binary Size-limit
❌ Size increased by 5.50KB from 47.99MB to 48.00MB (⬆️0.01%) |
Timeless0911
previously approved these changes
Jan 16, 2026
Merging this PR will not alter performance
Comparing 
Footnotes
|
The base branch was changed.
7d0cf92 to
6e4f76e
Compare
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for rendering ES module import and export statements with string specifiers, which allows using identifiers that are not valid JavaScript variable names (e.g., import {"a.b" as foo} or export {foo as "b.c"}).
Changes:
- Introduced
export_nameutility function to properly quote export/import specifiers when needed - Updated ESM library rendering to use
export_namefor all import/export specifier generation - Added comprehensive test case demonstrating string specifier support with module splitting
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| crates/rspack_core/src/utils/property_name.rs | Adds export_name function to handle quoting of ES module specifiers |
| crates/rspack_plugin_esm_library/src/render.rs | Updates all import/export statement generation to use export_name for proper string specifier handling |
| tests/rspack-test/esmOutputCases/re-exports/string-specifier/rspack.config.js | Configures test with module rules and chunk splitting |
| tests/rspack-test/esmOutputCases/re-exports/string-specifier/lib.js | Test library exporting with string specifier |
| tests/rspack-test/esmOutputCases/re-exports/string-specifier/index.js | Test entry point importing and re-exporting with string specifiers |
| tests/rspack-test/esmOutputCases/re-exports/string-specifier/snapshots/esm.snap.txt | Expected output snapshot verifying correct rendering of string specifiers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/rspack-test/esmOutputCases/re-exports/string-specifier/rspack.config.js
Show resolved
Hide resolved
ahabhgk
approved these changes
Jan 21, 2026
LingyuCoder
pushed a commit
that referenced
this pull request
Jan 21, 2026
feat: support export string specifier
chenjiahan
pushed a commit
that referenced
this pull request
Jan 21, 2026
feat: support export string specifier
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
support render import and export string specifier
Related links
Checklist