Skip to content

Conversation

@CPunisher
Copy link
Contributor

Summary

There are 192 cores in our CI machines, the original threads are counted as following:

  • Rayon workers: no limit, 192 by default
  • Tokio workers: no limit, 192 by default
  • Tokio blocking workers: limit to 256
    The total threads sum up to 640, exceeding the 500 max threads limitation of valgrind.

This pr limit rayon workers to 1, tokio workers to 8, and tokio blocking worker to 8. Valgrind is the single thread simulator, so less threads means faster CI and more stable bench results. But I'm afraid rspack will go to deadlock if we set a too small number of tokio workers.

This pr also switch @codspeed/actions to the official one.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings January 16, 2026 08:25
@CPunisher CPunisher review requested due to automatic review settings January 16, 2026 08:25
@netlify
Copy link

netlify bot commented Jan 16, 2026

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit ed203dd
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/6969f60b6d0f550008e8b434

@github-actions
Copy link
Contributor

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 0 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB 0
react-1k 825.4 KB 0
react-5k 2.7 MB 0
rome 984.2 KB 0
ui-components 2.1 MB 0

Generated by Rsdoctor GitHub Action

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jan 16, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 16, 2026

Merging this PR will not alter performance

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark1


Comparing 01-16-chore/limit-bench-threads (ed203dd) with main (cc18589)2

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

  2. No successful run was found on main (8c8a402) during the generation of this report, so cc18589 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@CPunisher CPunisher enabled auto-merge (squash) January 16, 2026 08:51
@github-actions
Copy link
Contributor

📦 Binary Size-limit

Comparing ed203dd to refactor: move all artifacts together (#12755) by hardfist

🙈 Size remains the same at 47.99MB

@CPunisher CPunisher merged commit fe1e14c into main Jan 16, 2026
61 checks passed
@CPunisher CPunisher deleted the 01-16-chore/limit-bench-threads branch January 16, 2026 09:03
LingyuCoder pushed a commit that referenced this pull request Jan 19, 2026
LingyuCoder pushed a commit that referenced this pull request Jan 19, 2026
chenjiahan pushed a commit that referenced this pull request Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants