-
-
Notifications
You must be signed in to change notification settings - Fork 757
chore: limit threads for codspeed benchmark #12763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rspack canceled.
|
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Merging this PR will not alter performance
Comparing Footnotes
|
📦 Binary Size-limit
🙈 Size remains the same at 47.99MB |
Summary
There are 192 cores in our CI machines, the original threads are counted as following:
The total threads sum up to 640, exceeding the 500 max threads limitation of valgrind.
This pr limit rayon workers to 1, tokio workers to 8, and tokio blocking worker to 8. Valgrind is the single thread simulator, so less threads means faster CI and more stable bench results. But I'm afraid rspack will go to deadlock if we set a too small number of tokio workers.
This pr also switch @codspeed/actions to the official one.
Checklist