Skip to content

chore: update Node.js version in .nvmrc to 22 #12797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chenjiahan merged 1 commit into from
Jan 21, 2026
Merged

chore: update Node.js version in .nvmrc to 22 #12797

chenjiahan merged 1 commit into from
Jan 21, 2026

Conversation

@chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Jan 21, 2026

Summary

Update Node.js version in .nvmrc to 22 to fix Cloudflare deployment.

image

Copilot AI review requested due to automatic review settings January 21, 2026 01:01
@netlify
Copy link

netlify bot commented Jan 21, 2026 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 2d06a4e
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/6970254ef03f3300085a949a

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jan 21, 2026
Copilot AI reviewed Jan 21, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s local Node.js version pin to Node 22 to resolve Cloudflare deployment compatibility.

Changes:

  • Update .nvmrc to use Node.js 22 instead of the previous LTS alias.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 21, 2026

Deploying rspack-v2 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2d06a4e
Status: ✅  Deploy successful!
Preview URL: https://8ec9624c.rspack-v2.pages.dev
Branch Preview URL: https://update-nvm-rc-0121.rspack-v2.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 5 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB -
react-1k 825.4 KB -
react-5k 2.7 MB -
ui-components 2.1 MB -
rome 984.2 KB -
📋 Detailed Reports (Click to expand)

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 5.7 MB - -
📄 JavaScript 5.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 825.4 KB - -
📄 JavaScript 825.4 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.7 MB - -
📄 JavaScript 2.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.1 MB - -
📄 JavaScript 2.0 MB - -
🎨 CSS 83.0 KB - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 984.2 KB - -
📄 JavaScript 984.2 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

📦 Binary Size-limit

Comparing 2d06a4e to chore: release v1.7.3 (#12788) by Gengkun

🙈 Size remains the same at 47.99MB

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 21, 2026

Merging this PR will not alter performance

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark1

Comparing update_nvm_rc_0121 (2d06a4e) with main (6f161b5)

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

@chenjiahan chenjiahan merged commit d11b7e1 into main Jan 21, 2026
62 checks passed
@chenjiahan chenjiahan deleted the update_nvm_rc_0121 branch January 21, 2026 01:25
LingyuCoder pushed a commit that referenced this pull request Jan 21, 2026
@chenjiahan @LingyuCoder
chore: update Node.js version in .nvmrc to 22 (#12797)
f06287a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chenjiahan