refactor: differentiate snapshot strategies by dependency type #12805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the snapshot strategy system to differentiate between different types of dependencies (file, context, missing, and build dependencies) and apply appropriate hashing strategies for each type.
Changes:
- Introduced
SnapshotTypeenum to distinguish between FILE, CONTEXT, MISSING, and BUILD dependency types - Split hash calculation into separate
file_hash()anddir_hash()methods with dedicated caches for each - Renamed
Strategy::PathHashtoStrategy::FileHashand added newStrategy::ContextHashandStrategy::Failedvariants - Added
updated_files()method toFileCounterto track files that were removed then re-added
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/rspack_core/src/utils/file_counter/mod.rs | Added updated_files() method to expose updated file tracking from IncrementalInfo |
| crates/rspack_core/src/compilation/mod.rs | Extended dependency methods to return updated files iterator in addition to added and removed |
| crates/rspack_core/src/cache/persistent/snapshot/strategy/mod.rs | Refactored Strategy enum with FileHash, ContextHash, and Failed variants; renamed test from validate_path_hash to validate_file_hash |
| crates/rspack_core/src/cache/persistent/snapshot/strategy/hash_helper.rs | Split content hashing into file_hash and dir_hash methods with separate caching, supporting different validation strategies |
| crates/rspack_core/src/cache/persistent/snapshot/mod.rs | Added SnapshotType enum and updated add() method to accept snapshot type for appropriate strategy selection |
| crates/rspack_core/src/cache/persistent/mod.rs | Updated after_compile to track file dependencies, context dependencies, and missing dependencies with appropriate snapshot types |
| crates/rspack_core/src/cache/persistent/build_dependencies/mod.rs | Updated to use SnapshotType::BUILD when adding build dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
crates/rspack_core/src/cache/persistent/snapshot/strategy/mod.rs
Outdated
Show resolved
Hide resolved
Contributor
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Contributor
📦 Binary Size-limit
❌ Size increased by 3.00KB from 48.01MB to 48.01MB (⬆️0.01%) |
Merging this PR will not alter performance
Comparing 
Footnotes
|
Deploying rspack-v2 with
|
| Latest commit: |
02e71b4
|
| Status: | 🚫 Build failed. |
c19b7bc to
0c9c3be
Compare
LingyuCoder
approved these changes
Jan 22, 2026
2 tasks
LingyuCoder
pushed a commit
that referenced
this pull request
Jan 22, 2026
* refactor: differentiate snapshot strategies by dependency type * fix: ci * feat: independent snapshot scope for different dependency types
Merged
2 tasks
LingyuCoder
pushed a commit
that referenced
this pull request
Jan 22, 2026
* refactor: differentiate snapshot strategies by dependency type * fix: ci * feat: independent snapshot scope for different dependency types
hardfist
pushed a commit
that referenced
this pull request
Jan 22, 2026
* refactor: differentiate snapshot strategies by dependency type * fix: ci * feat: independent snapshot scope for different dependency types
This was referenced Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Snapshot strategies should distinguish between file_dependencies and context_dependencies. For example, a directory in a file dependency simply means that the directory should exist, while a directory in a context dependency means that it should monitor all its child files.
This PR will add corresponding strategies for different dependency types.
Related links
Checklist