fix(mf): filter runtime plugin invocation for used exports #12807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When usedExports optimization is enabled, runtime plugin imports may be tree-shaken to undefined. This change defers plugin invocation by first collecting plugin references and params as objects, then filtering out undefined plugins before invoking them.
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where runtime plugins could fail when the usedExports optimization is enabled in rspack. When tree-shaking is active, unused exports are removed and may become undefined, causing runtime errors when the code attempts to invoke them as functions.
Changes:
- Modified the runtime plugin initialization to wrap plugins in objects containing both the plugin and its parameters
- Added a filter step to remove undefined plugins (those tree-shaken away) before invocation
- Added comprehensive test case covering the bug scenario with workers and Module Federation runtime plugins
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/rspack/src/container/ModuleFederationPlugin.ts | Core fix: wraps runtime plugins in objects and adds filter/map chain to remove undefined plugins before invocation |
| tests/rspack-test/configCases/container-1-5/runtime-plugin-with-used-exports/rspack.config.js | Test configuration enabling usedExports optimization with runtime plugins |
| tests/rspack-test/configCases/container-1-5/runtime-plugin-with-used-exports/index.js | Test assertions verifying plugin functionality and worker communication |
| tests/rspack-test/configCases/container-1-5/runtime-plugin-with-used-exports/bootstrap.js | Test helper setting up React import and worker for testing tree-shaking scenario |
| tests/rspack-test/configCases/container-1-5/runtime-plugin-with-used-exports/worker.js | Worker implementation for testing concurrent execution with tree-shaking |
| tests/rspack-test/configCases/container-1-5/runtime-plugin-with-used-exports/runtime-plugin.js | Sample runtime plugin that overrides React dependency resolution |
| tests/rspack-test/configCases/container-1-5/runtime-plugin-with-used-exports/node_modules/react.js | Mock React module for testing dependency resolution |
| tests/rspack-test/configCases/container-1-5/runtime-plugin-with-params/rspack.config.js | Removed unused output configuration and adjusted indentation |
| tests/rspack-test/configCases/container-1-5/runtime-plugin-with-params/index.js | Fixed indentation to be consistent with tabs throughout the file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/rspack-test/configCases/container-1-5/runtime-plugin-with-params/rspack.config.js
Show resolved
Hide resolved
tests/rspack-test/configCases/container-1-5/runtime-plugin-with-used-exports/runtime-plugin.js
Show resolved
Hide resolved
tests/rspack-test/configCases/container-1-5/runtime-plugin-with-used-exports/rspack.config.js
Show resolved
Hide resolved
Contributor
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 48.01MB |
Merging this PR will not alter performance
Comparing 
Footnotes
|
LingyuCoder
approved these changes
Jan 21, 2026
2 tasks
LingyuCoder
pushed a commit
that referenced
this pull request
Jan 22, 2026
LingyuCoder
pushed a commit
that referenced
this pull request
Jan 22, 2026
hardfist
pushed a commit
that referenced
this pull request
Jan 22, 2026
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When usedExports optimization is enabled, runtime plugin imports may be tree-shaken to undefined. This change add a filter for plugins invocation to avoid calling undefined as a function
fix #12605
Related links
Checklist