Skip to content

Conversation

@9aoy
Copy link
Contributor

@9aoy 9aoy commented Jan 22, 2026

Summary

Hide skipped tests logs, it can help to reduce noise in the test output when there are many skipped test files, especially when running tests with filters.

before:
image

after:
image

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings January 22, 2026 03:33
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jan 22, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a configuration option to hide skipped test files in the test output, helping to reduce noise when running tests with filters. The change requires upgrading the @rstest/core testing framework to version ^0.8.0 to support the new feature.

Changes:

  • Added hideSkippedTestFiles: true configuration to the rstest config
  • Updated @rstest/core dependency from ^0.7.9 to ^0.8.0

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
tests/rspack-test/rstest.config.ts Added hideSkippedTestFiles: true to the test configuration to hide skipped test files from output
tests/rspack-test/package.json Updated @rstest/core dependency version from ^0.7.9 to ^0.8.0
package.json Updated @rstest/core dependency version from ^0.7.9 to ^0.8.0
pnpm-lock.yaml Updated lockfile with new @rstest/core@0.8.0 resolution and transitive dependency updates (@rsbuild/core: 1.7.1 → 1.7.2)
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2026

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 0 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB 0
react-1k 825.4 KB 0
react-5k 2.7 MB 0
rome 984.2 KB 0
ui-components 2.1 MB 0

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2026

📦 Binary Size-limit

Comparing 05b467c to fix: handle rs.requireActual and rs.importActual in all contexts (#12806) by 9aoy

🙈 Size remains the same at 48.01MB

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 22, 2026

Deploying rspack-v2 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 05b467c
Status: ✅  Deploy successful!
Preview URL: https://ba1613a8.rspack-v2.pages.dev
Branch Preview URL: https://hideskippedtestfiles.rspack-v2.pages.dev

View logs

@9aoy 9aoy requested a review from hardfist as a code owner January 22, 2026 04:04
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 22, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing hideSkippedTestFiles (05b467c) with main (e31ee70)

Summary

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark1

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

@9aoy 9aoy requested review from LingyuCoder and chenjiahan and removed request for hardfist January 22, 2026 04:53
@9aoy 9aoy enabled auto-merge (squash) January 22, 2026 05:09
@9aoy 9aoy merged commit 6a174db into main Jan 22, 2026
74 of 77 checks passed
@9aoy 9aoy deleted the hideSkippedTestFiles branch January 22, 2026 05:10
LingyuCoder pushed a commit that referenced this pull request Jan 22, 2026
* test: hideSkippedTestFiles

* test: add more message for chunk-graph assert error

* test(rspack-cli): truncateThreshold
LingyuCoder pushed a commit that referenced this pull request Jan 22, 2026
* test: hideSkippedTestFiles

* test: add more message for chunk-graph assert error

* test(rspack-cli): truncateThreshold
hardfist pushed a commit that referenced this pull request Jan 22, 2026
* test: hideSkippedTestFiles

* test: add more message for chunk-graph assert error

* test(rspack-cli): truncateThreshold
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants