plugins/woocommerce/src/Internal/DataStores/Orders/OrdersTableDataStore.php (1)

2167-2175: Missing (float) cast on $cogs_value after the null check — inconsistent with item-level counterpart

The item-level save_cogs_data in abstract-wc-order-item-type-data-store.php explicitly casts after the null check:

$cogs_value = (float) $cogs_value;

This method omits that cast. There are two downstream consequences:

1. Line 2172 — $sync_meta strict-comparison (!==) may fire spuriously. If the filter returns an int or string that is numerically equal to $cogs_value_original, PHP's !== treats them as unequal (type mismatch), setting $sync_meta = true and triggering an unnecessary DB write — defeating the optimisation.

2. Line 2175 — 0.0 === $cogs_value strict-comparison may miss the delete branch. If the filter returns 0 (int) instead of 0.0 (float), the delete branch is skipped; the code falls through to the update or add branch, storing the wrong type and leaving a stale meta row instead of removing it.

Both issues are guarded by the @param float|null docblock, but extension developers are not guaranteed to honour it.

🛡️ Proposed fix — add the cast immediately after the null check

  $cogs_value = apply_filters( 'woocommerce_save_order_cogs_value', $cogs_value_original, $order );
  if ( null === $cogs_value ) {
      return;
  }
+
+ $cogs_value = (float) $cogs_value;

  $sync_meta = $changed_via_order_object || $cogs_value_original !== $cogs_value;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@plugins/woocommerce/src/Internal/DataStores/Orders/OrdersTableDataStore.php`
around lines 2167 - 2175, The $cogs_value returned from apply_filters in the
OrdersTableDataStore save routine must be normalized to a float after the null
check to match the item-level behavior and avoid type-strict comparison bugs; so
in the method handling $cogs_value (the block using $cogs_value_original,
$cogs_value, apply_filters('woocommerce_save_order_cogs_value', ...), $sync_meta
and the subsequent 0.0 === $cogs_value check and
data_store_meta->get_metadata_by_key($order, '_cogs_total_value')), cast
$cogs_value to (float) immediately after confirming it is not null so strict !==
and === comparisons behave correctly and deletions/updates are not skipped or
wrongly triggered.

plugins/woocommerce/src/Internal/DataStores/Orders/OrdersTableDataStore.php (2)

2167-2175: Add a (float) cast after the null check — inconsistent with item data store and causes two correctness gaps.

apply_filters can return any type. Without a cast, two issues arise:

1. $cogs_value_original !== $cogs_value (line 2172) is a strict comparison. If a filter returns int 0 or string "0" for a zero-CoGS order, 0.0 !== 0 → true → $sync_meta = true → a write is forced on every subsequent save, defeating the optimisation.

2. 0.0 === $cogs_value (line 2175) is a strict comparison. With int 0 the check is false, so the delete branch is bypassed and the elseif/else branch runs instead — updating or inserting meta with an integer value rather than deleting it.

The analogous save_cogs_data in abstract-wc-order-item-type-data-store.php (line 243) explicitly casts: $cogs_value = (float) $cogs_value; after the null check. This PR should do the same.

♻️ Proposed fix

     if ( null === $cogs_value ) {
         return;
     }

+    $cogs_value = (float) $cogs_value;
+
     $sync_meta = $changed_via_order_object || $cogs_value_original !== $cogs_value;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@plugins/woocommerce/src/Internal/DataStores/Orders/OrdersTableDataStore.php`
around lines 2167 - 2175, After the null check on $cogs_value (right after
apply_filters in OrdersTableDataStore), cast the filter result to float (e.g.
$cogs_value = (float) $cogs_value;) so comparisons against $cogs_value_original
and the strict checks like 0.0 === $cogs_value behave consistently; update the
code around $cogs_value_original, $cogs_value and the metadata logic that calls
$this->data_store_meta->get_metadata_by_key to rely on the normalized float
value.

---

2183-2188: else branch creates a 0-value _cogs_total_value meta row that serves no purpose.

When $sync_meta = true (e.g., first checkout save with products having no CoGS set), $cogs_value = 0.0, and no existing meta: the else branch inserts a new row with value 0.0. read_cogs_data at line 1426 treats both "absent meta" and "meta = 0" identically, so the row has no semantic benefit. The item-level save_cogs_data in abstract-wc-order-item-type-data-store.php (lines 243–249) avoids this by only writing non-zero values.

♻️ Proposed fix

-    } else {
+    } elseif ( 0.0 !== $cogs_value ) {
         $meta        = new \WC_Meta_Data();
         $meta->key   = '_cogs_total_value';
         $meta->value = $cogs_value;
         $this->data_store_meta->add_meta( $order, $meta );
     }

Note: If the (float) cast from the previous suggestion is applied first, the 0.0 !== $cogs_value guard here is guaranteed to be a clean float comparison.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@plugins/woocommerce/src/Internal/DataStores/Orders/OrdersTableDataStore.php`
around lines 2183 - 2188, The else branch in OrdersTableDataStore is inserting a
redundant _cogs_total_value meta row with 0.0; modify the logic so you only call
$this->data_store_meta->add_meta($order, $meta) when $cogs_value is non-zero
(use a strict float check, e.g. $cogs_value !== 0.0 after casting to float
earlier), matching the item-level save_cogs_data behavior and keeping
read_cogs_data semantics consistent; ensure you reference the same meta key
'_cogs_total_value' and the data_store_meta->add_meta call when making the
change.

plugins/woocommerce/src/Internal/DataStores/Orders/OrdersTableDataStore.php (2)

2173-2189: else branch adds a redundant 0.0 meta entry when CoGS is zero and no existing meta.

When $sync_meta = true (e.g., because $cogs_value_changed = true), $cogs_value = 0.0, and $existing_meta is empty, the else branch fires and executes an unnecessary add_meta call. Since read_cogs_data defaults to 0 when no _cogs_total_value meta exists, storing 0.0 is semantically equivalent to storing nothing — and costs one SQL against the optimization goal of this PR.

♻️ Proposed fix

-		} else {
+		} elseif ( 0.0 !== $cogs_value ) {
 			$meta        = new \WC_Meta_Data();
 			$meta->key   = '_cogs_total_value';
 			$meta->value = $cogs_value;
 			$this->data_store_meta->add_meta( $order, $meta );
 		}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@plugins/woocommerce/src/Internal/DataStores/Orders/OrdersTableDataStore.php`
around lines 2173 - 2189, The code currently calls add_meta in the else branch
even when $cogs_value === 0.0 and no existing meta, creating a redundant
zero-valued meta; update the logic in OrdersTableDataStore (the block using
$sync_meta, $cogs_value and $existing_meta) so that you only call
$this->data_store_meta->add_meta($order, $meta) when $cogs_value is not 0.0
(e.g., add a guard like if ( 0.0 !== $cogs_value ) before constructing and
adding the new \WC_Meta_Data), leaving the existing delete_meta path intact for
existing zero metas and skipping any insert when value is zero and no meta
exists.

---

2143-2143: Add guard to prevent storing CoGS meta when value is 0 on new orders.

The else branch at lines 2183–2188 adds _cogs_total_value meta even when the value is 0.0, but only for new orders (when no existing meta exists). The delete branch at lines 2173–2176 correctly removes the meta when the value is 0.0 and existing meta is present. To maintain consistency and avoid unnecessary database writes, guard the else clause to skip adding meta for zero values:

Suggested fix

} elseif ( 0.0 !== $cogs_value ) {
    $meta        = new \WC_Meta_Data();
    $meta->key   = '_cogs_total_value';
    $meta->value = $cogs_value;
    $this->data_store_meta->add_meta( $order, $meta );
}

This aligns with the behavior in the existing test test_saving_order_saves_cogs_value_if_not_zero_and_cogs_enabled (lines 3861–3865), which expects no meta to be stored when CoGS is set to 0.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@plugins/woocommerce/src/Internal/DataStores/Orders/OrdersTableDataStore.php`
at line 2143, The else branch in OrdersTableDataStore::save_cogs_data currently
adds a _cogs_total_value meta even when $cogs_value is 0.0; update the branch
that constructs a new \WC_Meta_Data and calls $this->data_store_meta->add_meta(
$order, $meta ) to only run when $cogs_value !== 0.0 (or 0.0 !== $cogs_value),
so zero values do not create the meta and mirror the delete behavior that
removes existing zero-value meta.