[Performance] - Remove unnecessary calculate_totals() call in CartCoupons DELETE handler by Abdalsalaam · Pull Request #63404 · woocommerce/woocommerce

Abdalsalaam · 2026-02-22T20:41:58Z

Submission Review Guidelines:

I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have reviewed my code for security best practices.
Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

DELETE /wc/store/v1/cart/coupons called $cart->calculate_totals() after removing all coupons, but the result was never used, the endpoint immediately returns an empty []response body with no cart totals.

This PR removes the unnecessary calculate_totals() call from CartCoupons::get_route_delete_response().
The next consumer request (GET /cart) will trigger recalculation via CartController::get_cart_for_response() as designed.
AbstractCartRoute::cart_updated() documents this explicitly: "This does not trigger a recalculation of the cart, endpoints should have already done so before returning the cart response."

(For Bug Fixes) Bug introduced in PR # .

Screenshots or screen recordings:

N/A — logic change, no visual output.

Before	After

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Create a coupon in WooCommerce admin (e.g. SAVE10).
Add a product to the cart and apply the coupon via POST /wc/store/v1/cart/coupons with body {"code": "SAVE10"}.
Call GET /wc/store/v1/cart and note the discounted totals, confirm SAVE10 appears in the coupon list.
Call DELETE /wc/store/v1/cart/coupons and confirm the response is 200 [].
Call GET /wc/store/v1/cart again and confirm the coupon list is empty and totals reflect full price with no discount.

Testing that has already taken place:

Milestone

Automatically assign milestone for the next WooCommerce version

Note: Check the box above to have the milestone automatically assigned when merged.
Alternatively (e.g. for point releases), manually assign the appropriate milestone.

Changelog entry

Automatically create a changelog entry from the details below.

This Pull Request does not require a changelog entry. (Comment required below)

Changelog Entry Details

Significance

Patch
Minor
Major

Type

Fix - Fixes an existing bug
Add - Adds functionality
Update - Update existing functionality
Dev - Development related task
Tweak - A minor adjustment to the codebase
Performance - Address performance issues
Enhancement - Improvement to existing functionality

Message

Remove unnecessary calculate_totals() call from DELETE /wc/store/v1/cart/coupons. The result was never used since the endpoint returns an empty response body.

Changelog Entry Comment

Comment

github-actions · 2026-02-22T20:42:07Z

Testing Guidelines

Hi @woocommerce/rubik,

Apart from reviewing the code changes, please make sure to review the testing instructions (Guide) and verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed.

Reminder: PR reviewers are required to document testing performed. This includes:

🖼️ Screenshots or screen recordings.
📝 List of functionality tested / steps followed.
🌐 Site details (environment attributes such as hosting type, plugins, theme, store size, store age, and relevant settings).
🔍 Any analysis performed, such as assessing potential impacts on environment attributes and other plugins, conducting performance profiling, or using LLM/AI-based analysis.

⚠️ Within the testing details you provide, please ensure that no sensitive information (such as API keys, passwords, user data, etc.) is included in this public issue.

…mmerce

coderabbitai · 2026-02-22T20:43:55Z

📝 Walkthrough

Walkthrough

Removes a redundant calculate_totals() call from the DELETE cart coupons endpoint, since the endpoint returns an empty response body. Includes a changelog entry documenting this performance-focused change.

Changes

Cohort / File(s)	Summary
Cart Coupons Delete Endpoint Optimization `plugins/woocommerce/changelog/63404-fix-delete-cart-coupons-performance`, `plugins/woocommerce/src/StoreApi/Routes/V1/CartCoupons.php`	Removed unnecessary `calculate_totals()` call from the delete coupon response handler and added corresponding patch changelog entry noting the performance improvement.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description provides detailed context about the change, including the problem statement, implementation details, and comprehensive testing instructions.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title accurately describes the main change: removing an unnecessary calculate_totals() call from the CartCoupons DELETE handler, which is a clear performance optimization.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings (stacked PR)
📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

…pons DELETE handler (#63404) * remove unnecessary calculate_totals * Add changefile(s) from automation for the following project(s): woocommerce --------- Co-authored-by: woocommercebot <woocommercebot@users.noreply.github.com>

remove unnecessary calculate_totals

f630c08

Abdalsalaam requested a review from a team as a code owner February 22, 2026 20:41

Abdalsalaam requested review from opr and removed request for a team February 22, 2026 20:41

github-actions Bot added the type: community contribution label Feb 22, 2026

github-actions Bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 22, 2026

woocommercebot requested review from a team, ObliviousHarmony and kmanijak and removed request for a team February 22, 2026 20:42

Add changefile(s) from automation for the following project(s): wooco…

6260a31

…mmerce

Abdalsalaam changed the title ~~Remove unnecessary calculate_totals() call in CartCoupons DELETE handler~~ [Performance] - Remove unnecessary calculate_totals() call in CartCoupons DELETE handler Feb 22, 2026

kmanijak removed their request for review February 23, 2026 09:45

Merge branch 'trunk' into fix/delete-cart-coupons-performance

b611aa7

senadir approved these changes Mar 6, 2026

View reviewed changes

senadir enabled auto-merge (squash) March 6, 2026 15:39

senadir merged commit 50a794d into woocommerce:trunk Mar 6, 2026
32 checks passed

github-actions Bot added this to the 10.7.0 milestone Mar 6, 2026

Abdalsalaam deleted the fix/delete-cart-coupons-performance branch April 27, 2026 13:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Performance] - Remove unnecessary calculate_totals() call in CartCoupons DELETE handler#63404

[Performance] - Remove unnecessary calculate_totals() call in CartCoupons DELETE handler#63404
senadir merged 3 commits intowoocommerce:trunkfrom
Abdalsalaam:fix/delete-cart-coupons-performance

Abdalsalaam commented Feb 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Feb 22, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Feb 22, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Abdalsalaam commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Submission Review Guidelines:

Changes proposed in this Pull Request:

Screenshots or screen recordings:

How to test the changes in this Pull Request:

Testing that has already taken place:

Milestone

Changelog entry

Significance

Type

Message

Comment

Uh oh!

github-actions Bot commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing Guidelines

Uh oh!

coderabbitai Bot commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Abdalsalaam commented Feb 22, 2026 •

edited

Loading

github-actions Bot commented Feb 22, 2026 •

edited

Loading

coderabbitai Bot commented Feb 22, 2026 •

edited

Loading