feat: ability to avoid CLIRR dependency resolution#959
Merged
suztomo merged 1 commit intogoogleapis:mainfrom Jan 7, 2025
Merged
feat: ability to avoid CLIRR dependency resolution#959suztomo merged 1 commit intogoogleapis:mainfrom
suztomo merged 1 commit intogoogleapis:mainfrom
Conversation
CLIRR Maven plugin's dependencies are quite old and not available in some build environment (Airlock). googleapis#956 Extracting this plugin declaration as a profile enables us to disable the CLIRR dependency resolution by `mvn -P=-clirr-compatibility-check ...`
zhumin8
approved these changes
Jan 7, 2025
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 7, 2025
🤖 I have created a release *beep* *boop* --- ## [1.13.0](https://togithub.com/googleapis/java-shared-config/compare/v1.12.3...v1.13.0) (2025-01-07) ### Features * Ability to avoid CLIRR dependency resolution ([#959](https://togithub.com/googleapis/java-shared-config/issues/959)) ([50198dd](https://togithub.com/googleapis/java-shared-config/commit/50198dd2f809752f1e483650a134f4439840f7c7)) ### Dependencies * Declare Maven clean and install plugins versions ([#960](https://togithub.com/googleapis/java-shared-config/issues/960)) ([22c5fa5](https://togithub.com/googleapis/java-shared-config/commit/22c5fa5740d4a077121d33bfeb556949fcb4a7e6)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #956
CLIRR Maven plugin's dependencies are quite old and not available in some build environment (Airlock).
Extracting this plugin declaration as a profile "clirr-compatibility-check" enables us to disable the CLIRR dependency resolution by
mvn -P=-clirr-compatibility-check ...Because the profile is activated by default for Java 8 and above, the CIs continue to run the CLIRR check without explicitly specifying the profile.