This repository was archived by the owner on Sep 26, 2023. It is now read-only.
fix: remove extends ApiMessage from HttpJsonStubCallableFactory definition#1426
Merged
vam-google merged 1 commit intogoogleapis:masterfrom Jul 13, 2021
Merged
fix: remove extends ApiMessage from HttpJsonStubCallableFactory definition#1426vam-google merged 1 commit intogoogleapis:masterfrom
extends ApiMessage from HttpJsonStubCallableFactory definition#1426vam-google merged 1 commit intogoogleapis:masterfrom
Conversation
…efinition This is needed to match DIREGAPIC architecture, which does not rely on ApiMessage but on the proto stubs instead.
miraleung
suggested changes
Jul 9, 2021
Contributor
miraleung
left a comment
There was a problem hiding this comment.
Wouldn't this be an API-breaking change for public dev users who use this library?
Contributor
Author
|
@miraleung I don't think so. I'm not even sure if it is breaking change on binary level (I guess it is no, as it passes the prebuilds). This makes the generic accept more stuff than before, so it expands the scope, not narrows it down, so everybody who was using the stuff with the more narrow scopse shoudl be able to use it. I actually tested it with compute client, and it is just fine (both new and old gaxes work on the same library). |
miraleung
approved these changes
Jul 13, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jul 19, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.67.0](https://www.github.com/googleapis/gax-java/compare/v1.66.0...v1.67.0) (2021-07-19) ### Features * introduce closeAsync to Batcher ([#1423](https://www.github.com/googleapis/gax-java/issues/1423)) ([aab5288](https://www.github.com/googleapis/gax-java/commit/aab528803405c2b5f9fc89641f47abff948a876d)) * optimize unary callables to not wait for trailers ([#1356](https://www.github.com/googleapis/gax-java/issues/1356)) ([dd5f955](https://www.github.com/googleapis/gax-java/commit/dd5f955a3ab740c677fbc6f1247094798eb814a3)) * update DirectPath environment variables ([#1412](https://www.github.com/googleapis/gax-java/issues/1412)) ([4f63b61](https://www.github.com/googleapis/gax-java/commit/4f63b61f1259936aa4a1eaf9162218c787b92f2a)) ### Bug Fixes * remove `extends ApiMessage` from `HttpJsonStubCallableFactory` definition ([#1426](https://www.github.com/googleapis/gax-java/issues/1426)) ([87636a5](https://www.github.com/googleapis/gax-java/commit/87636a5812874a77e9004aab07607121efa43736)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to match DIREGAPIC architecture, which does not rely on ApiMessage but on the proto stubs instead. This is also a prerequisite to making LRO a non-breaking change post GCE client GA.
The full set (without tests) of anticipated changes to support DIREGAPIC LRO can be found in 8588755 (a separate branch now). The rest of the changes are additive, that is why they can wait.