fix: make splitChunks more stable #12410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
📝 Benchmark detail: Open
Threshold exceeded: ["arco-pro_production-mode_persistent-hot + exec"] |
ahabhgk
previously approved these changes
Dec 10, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses potential instability issues in the SplitChunksPlugin that could cause inconsistent output during incremental rebuilds. The changes focus on ensuring deterministic behavior by introducing stable key generation, sorting collections before iteration, and using content-based hashing instead of potentially unstable identifiers.
Key changes:
- Introduced stable chunk identifier computation based on chunk names and runtime information
- Added sorting to all collection iterations to ensure deterministic processing order
- Replaced local hash caching with shared, thread-safe caching using DashMap
- Generated stable keys for module groups and chunk combinations using sorted, content-based hashing
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
crates/rspack_plugin_split_chunks/src/plugin/module_group.rs |
Added stable chunk ID mapping, stable key generation and caching, sorting of module groups and invalid group keys, and tie-breaker logic for deterministic module group selection |
crates/rspack_plugin_split_chunks/src/plugin/mod.rs |
Added sorting of modules before processing to ensure deterministic order |
crates/rspack_plugin_split_chunks/src/plugin/max_size.rs |
Introduced generate_stable_key method for deterministic group naming, updated sorting to use stable keys instead of first node's key |
crates/rspack_ids/src/named_chunk_ids_plugin.rs |
Added sorting of name-to-items map before processing to ensure deterministic chunk ID assignment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Rsdoctor Bundle Diff AnalysisFound 5 project(s) in monorepo. 📁 react-10kPath:
📦 Download Diff Report: react-10k Bundle Diff 📁 react-1kPath:
📦 Download Diff Report: react-1k Bundle Diff 📁 react-5kPath:
📦 Download Diff Report: react-5k Bundle Diff 📁 ui-componentsPath:
📦 Download Diff Report: ui-components Bundle Diff 📁 romePath:
📦 Download Diff Report: rome Bundle Diff Generated by Rsdoctor GitHub Action |
Contributor
📦 Binary Size-limit
❌ Size increased by 27.00KB from 48.19MB to 48.21MB (⬆️0.05%) |
CodSpeed Performance ReportMerging #12410 will not alter performanceComparing Summary
|
b2f537b to
c41c08c
Compare
c41c08c to
c5ec153
Compare
Contributor
|
📝 Benchmark detail: Open
|
ahabhgk
approved these changes
Dec 11, 2025
This was referenced Dec 11, 2025
Draft
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I found some potential vulnerabilities of
SplitChunksPlugin, this can make output inconsistent during incremental rebuild.Related links
Checklist