Skip to content

feat: stabilize inline exports #12475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahabhgk merged 2 commits into from
Dec 17, 2025
Merged

feat: stabilize inline exports #12475

ahabhgk merged 2 commits into from
Dec 17, 2025

Conversation

@ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Dec 16, 2025 •
edited
Loading

Summary

Add:

  • optimization.inlineExports: replace experiments.inlineConst, experiments.inlineEnum, and module.parser.javascript.inlineConst

Deprecated:

  • experiments.lazyBarrel, already stable and enabled by default
  • experiments.inlineConst, already stable and enabled by default, use optimization.inlineExports instead
  • experiments.inlineEnum, already stable, use builtin:swc-loader collectTypeScriptInfo.exportedEnum instead
  • experiments.typeReexportsPresence, already stable, use module.parser.javascript.typeReexportsPresence instead

Remove:

  • module.parser.javascript.inlineConst, use optimization.inlineExports instead

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Dec 16, 2025 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit f9b40a4
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/694224c1d8255d0008ea67c9
😎 Deploy Preview https://deploy-preview-12475--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Dec 16, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2025 •
edited
Loading

Rsdoctor Bundle Diff Analysis

Found 5 project(s) in monorepo.

📊 Quick Summary (Click to expand)
Project Total Size Change
react-10k 5.7 MB ➡️ 0 B (0.0%)
react-1k 823.4 KB ➡️ 0 B (0.0%)
react-5k 2.7 MB ➡️ 0 B (0.0%)
rome 984.3 KB ➡️ -38.0 B (-0.0%)
ui-components 2.1 MB ➡️ 41.0 B (0.0%)
📋 Detailed Reports (Click to expand)

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

📌 Baseline Commit: ec646ebb83 | PR: #12469

Metric Current Baseline Change
📊 Total Size 5.7 MB 5.7 MB 0 B (0.0%)
📄 JavaScript 5.7 MB 5.7 MB 0 B (0.0%)
🎨 CSS 21.0 B 21.0 B 0 B (0.0%)
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: react-10k Bundle Diff

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

📌 Baseline Commit: ec646ebb83 | PR: #12469

Metric Current Baseline Change
📊 Total Size 823.4 KB 823.4 KB 0 B (0.0%)
📄 JavaScript 823.4 KB 823.4 KB 0 B (0.0%)
🎨 CSS 0 B 0 B N/A
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: react-1k Bundle Diff

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

📌 Baseline Commit: ec646ebb83 | PR: #12469

Metric Current Baseline Change
📊 Total Size 2.7 MB 2.7 MB 0 B (0.0%)
📄 JavaScript 2.7 MB 2.7 MB 0 B (0.0%)
🎨 CSS 21.0 B 21.0 B 0 B (0.0%)
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: react-5k Bundle Diff

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

📌 Baseline Commit: ec646ebb83 | PR: #12469

Metric Current Baseline Change
📊 Total Size 984.3 KB 984.3 KB -38.0 B (-0.0%)
📄 JavaScript 984.3 KB 984.3 KB -38.0 B (-0.0%)
🎨 CSS 0 B 0 B N/A
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: rome Bundle Diff

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

📌 Baseline Commit: ec646ebb83 | PR: #12469

Metric Current Baseline Change
📊 Total Size 2.1 MB 2.1 MB 41.0 B (0.0%)
📄 JavaScript 2.0 MB 2.0 MB 41.0 B (0.0%)
🎨 CSS 83.0 KB 83.0 KB 0 B (0.0%)
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: ui-components Bundle Diff

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2025 •
edited
Loading

📦 Binary Size-limit

Comparing f9b40a4 to perf(rstest): minor performance optimization (#12469) by Max

🎉 Size decreased by 4.50KB from 48.29MB to 48.29MB (⬇️0.01%)

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 16, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #12475 will not alter performance

Comparing stable-inline (f9b40a4) with main (ec646eb)

Summary

✅ 17 untouched

@ahabhgk ahabhgk enabled auto-merge (squash) December 17, 2025 05:46
@ahabhgk ahabhgk merged commit ff4d368 into main Dec 17, 2025
56 checks passed
@ahabhgk ahabhgk deleted the stable-inline branch December 17, 2025 05:56
@chenjiahan
Copy link
Member

chenjiahan commented Dec 17, 2025

We can move the deprecated options to https://rspack.rs/config/deprecated-options

This was referenced Dec 17, 2025
Merged
Merged
@CPunisher CPunisher mentioned this pull request Dec 17, 2025
Merged
2 tasks
This was referenced Dec 17, 2025
Merged
Merged
@ahabhgk ahabhgk mentioned this pull request Dec 18, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SyMind SyMind SyMind approved these changes

@LingyuCoder LingyuCoder Awaiting requested review from LingyuCoder LingyuCoder is a code owner

@hardfist hardfist Awaiting requested review from hardfist hardfist is a code owner

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a h-a-n-a is a code owner

Assignees

No one assigned

Labels

release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ahabhgk @chenjiahan @SyMind